Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: blimp/client/app/compositor/browser_compositor.cc

Issue 2286273003: Make cc::Display not own its BeginFrameSource (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/compositor/browser_compositor.cc
diff --git a/blimp/client/app/compositor/browser_compositor.cc b/blimp/client/app/compositor/browser_compositor.cc
index 955968f917f399718d0d3e97c88d4844331686f1..de918a7a41b1abb92877d6f7c9ea27475933e48b 100644
--- a/blimp/client/app/compositor/browser_compositor.cc
+++ b/blimp/client/app/compositor/browser_compositor.cc
@@ -194,17 +194,16 @@ void BrowserCompositor::HandlePendingOutputSurfaceRequest() {
base::MakeUnique<DisplayOutputSurface>(context_provider);
auto* task_runner = base::ThreadTaskRunnerHandle::Get().get();
- std::unique_ptr<cc::SyntheticBeginFrameSource> begin_frame_source(
- new cc::DelayBasedBeginFrameSource(
- base::MakeUnique<cc::DelayBasedTimeSource>(task_runner)));
+ begin_frame_source_.reset(new cc::DelayBasedBeginFrameSource(
+ base::MakeUnique<cc::DelayBasedTimeSource>(task_runner)));
std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
- begin_frame_source.get(), task_runner,
+ begin_frame_source_.get(), task_runner,
display_output_surface->capabilities().max_frames_pending));
display_ = base::MakeUnique<cc::Display>(
nullptr /*shared_bitmap_manager*/,
BrowserCompositor::GetGpuMemoryBufferManager(),
- host_->settings().renderer_settings, std::move(begin_frame_source),
+ host_->settings().renderer_settings, begin_frame_source_.get(),
std::move(display_output_surface), std::move(scheduler),
base::MakeUnique<cc::TextureMailboxDeleter>(task_runner));
display_->SetVisible(true);

Powered by Google App Engine
This is Rietveld 408576698