Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: test/cctest/interpreter/bytecode_expectations/Generators.golden

Issue 2286273002: [interpreter] Make the comparison bytecode handlers collect type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/Generators.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Generators.golden b/test/cctest/interpreter/bytecode_expectations/Generators.golden
index 57dbfd153d163c83f940b1206bfb5a547d9ceae4..c59436c56c079347ba588487797bae79b7b82303 100644
--- a/test/cctest/interpreter/bytecode_expectations/Generators.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Generators.golden
@@ -15,14 +15,14 @@ snippet: "
"
frame size: 11
parameter count: 1
-bytecode array length: 201
+bytecode array length: 207
bytecodes: [
B(Ldar), R(new_target),
- B(JumpIfUndefined), U8(20),
+ B(JumpIfUndefined), U8(21),
B(ResumeGenerator), R(new_target),
B(Star), R(1),
B(LdaZero),
- B(TestEqualStrict), R(1),
+ B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrue), U8(57),
B(LdaSmi), U8(76),
B(Star), R(2),
@@ -53,10 +53,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(6), U8(1),
B(Star), R(8),
B(LdaZero),
- B(TestEqualStrict), R(8),
- B(JumpIfTrue), U8(31),
+ B(TestEqualStrict), R(8), U8(0),
+ B(JumpIfTrue), U8(32),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(8),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
B(LdaTrue),
@@ -89,13 +89,13 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorClose), R(5), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(4), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(16),
+ B(TestEqualStrict), R(2), U8(0),
+ B(JumpIfTrue), U8(18),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(13),
+ B(TestEqualStrict), R(2), U8(0),
+ B(JumpIfTrue), U8(14),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(2),
+ B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(10),
B(Jump), U8(11),
B(Ldar), R(3),
@@ -110,7 +110,7 @@ bytecodes: [
constant pool: [
]
handlers: [
- [39, 138, 144],
+ [40, 141, 147],
]
---
@@ -120,17 +120,17 @@ snippet: "
"
frame size: 11
parameter count: 1
-bytecode array length: 294
+bytecode array length: 304
bytecodes: [
B(Ldar), R(new_target),
- B(JumpIfUndefined), U8(26),
+ B(JumpIfUndefined), U8(28),
B(ResumeGenerator), R(new_target),
B(Star), R(1),
B(LdaZero),
- B(TestEqualStrict), R(1),
- B(JumpIfTrue), U8(63),
+ B(TestEqualStrict), R(1), U8(0),
+ B(JumpIfTrue), U8(64),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(1),
+ B(TestEqualStrict), R(1), U8(0),
B(JumpIfTrueConstant), U8(0),
B(LdaSmi), U8(76),
B(Star), R(2),
@@ -161,10 +161,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(6), U8(1),
B(Star), R(8),
B(LdaZero),
- B(TestEqualStrict), R(8),
- B(JumpIfTrue), U8(31),
+ B(TestEqualStrict), R(8), U8(0),
+ B(JumpIfTrue), U8(32),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(8),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
B(LdaTrue),
@@ -174,7 +174,7 @@ bytecodes: [
B(Star), R(3),
B(LdaZero),
B(Star), R(2),
- B(Jump), U8(113),
+ B(Jump), U8(115),
B(Ldar), R(7),
/* 11 E> */ B(Throw),
/* 16 S> */ B(LdaSmi), U8(42),
@@ -195,10 +195,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(5), U8(1),
B(Star), R(8),
B(LdaZero),
- B(TestEqualStrict), R(8),
- B(JumpIfTrue), U8(32),
+ B(TestEqualStrict), R(8), U8(0),
+ B(JumpIfTrue), U8(33),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(8),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(23),
B(Jump), U8(2),
B(LdaTrue),
@@ -231,16 +231,16 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorClose), R(5), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(4), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(22),
+ B(TestEqualStrict), R(2), U8(0),
+ B(JumpIfTrue), U8(25),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(19),
+ B(TestEqualStrict), R(2), U8(0),
+ B(JumpIfTrue), U8(21),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(16),
+ B(TestEqualStrict), R(2), U8(0),
+ B(JumpIfTrue), U8(17),
B(LdaSmi), U8(3),
- B(TestEqualStrict), R(2),
+ B(TestEqualStrict), R(2), U8(0),
B(JumpIfTrue), U8(13),
B(Jump), U8(14),
B(Ldar), R(3),
@@ -258,7 +258,7 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [45, 222, 228],
+ [47, 228, 234],
]
---
@@ -268,17 +268,17 @@ snippet: "
"
frame size: 18
parameter count: 1
-bytecode array length: 742
+bytecode array length: 763
bytecodes: [
B(Ldar), R(new_target),
- B(JumpIfUndefined), U8(26),
+ B(JumpIfUndefined), U8(28),
B(ResumeGenerator), R(new_target),
B(Star), R(4),
B(LdaZero),
- B(TestEqualStrict), R(4),
- B(JumpIfTrue), U8(63),
+ B(TestEqualStrict), R(4), U8(0),
+ B(JumpIfTrue), U8(64),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(4),
+ B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrueConstant), U8(3),
B(LdaSmi), U8(76),
B(Star), R(5),
@@ -309,10 +309,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(9), U8(1),
B(Star), R(11),
B(LdaZero),
- B(TestEqualStrict), R(11),
- B(JumpIfTrue), U8(31),
+ B(TestEqualStrict), R(11), U8(0),
+ B(JumpIfTrue), U8(32),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(11),
+ B(TestEqualStrict), R(11), U8(0),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
B(LdaTrue),
@@ -341,10 +341,10 @@ bytecodes: [
/* 30 E> */ B(Call), R(12), R(13), U8(1), U8(1),
/* 30 E> */ B(StaContextSlot), R(1), U8(7),
B(LdaSmi), U8(-2),
- B(TestEqual), R(4),
- B(JumpIfTrue), U8(17),
+ B(TestEqual), R(4), U8(0),
+ B(JumpIfTrue), U8(18),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(4),
+ B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrueConstant), U8(9),
B(LdaSmi), U8(76),
B(Star), R(12),
@@ -399,10 +399,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(12), U8(1),
B(Star), R(15),
B(LdaZero),
- B(TestEqualStrict), R(15),
- B(JumpIfTrue), U8(43),
+ B(TestEqualStrict), R(15), U8(0),
+ B(JumpIfTrue), U8(44),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(15),
+ B(TestEqualStrict), R(15), U8(0),
B(JumpIfTrue), U8(34),
B(Jump), U8(2),
B(LdaTrue),
@@ -418,15 +418,15 @@ bytecodes: [
B(Star), R(9),
B(LdaZero),
B(Star), R(8),
- B(Jump), U8(68),
+ B(Jump), U8(69),
B(Ldar), R(13),
/* 36 E> */ B(Throw),
B(Ldar), R(13),
B(PopContext), R(2),
B(LdaZero),
B(StaContextSlot), R(1), U8(9),
- B(Wide), B(Jump), U16(-215),
- B(Jump), U8(39),
+ B(Wide), B(Jump), U16(-219),
+ B(Jump), U8(40),
B(Star), R(12),
B(Ldar), R(closure),
B(CreateCatchContext), R(12), U8(11),
@@ -434,7 +434,7 @@ bytecodes: [
B(PushContext), R(2),
B(LdrContextSlot), R(0), U8(9), R(12),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(12),
+ B(TestEqualStrict), R(12), U8(13),
B(JumpIfFalse), U8(7),
B(LdaSmi), U8(1),
B(StaContextSlot), R(0), U8(9),
@@ -451,29 +451,29 @@ bytecodes: [
B(Star), R(10),
B(LdrContextSlot), R(1), U8(9), R(11),
B(LdaZero),
- B(TestEqualStrict), R(11),
+ B(TestEqualStrict), R(11), U8(14),
B(JumpIfTrueConstant), U8(15),
B(LdrContextSlot), R(1), U8(7), R(11),
B(LdaUndefined),
- B(TestEqualStrict), R(11),
+ B(TestEqualStrict), R(11), U8(15),
B(JumpIfTrueConstant), U8(16),
B(LdrContextSlot), R(1), U8(7), R(11),
- B(LdaNamedProperty), R(11), U8(12), U8(13),
+ B(LdaNamedProperty), R(11), U8(12), U8(16),
B(StaContextSlot), R(1), U8(11),
B(LdrContextSlot), R(1), U8(11), R(11),
B(LdaNull),
- B(TestEqual), R(11),
+ B(TestEqual), R(11), U8(18),
B(JumpIfFalse), U8(4),
- B(Jump), U8(117),
+ B(Jump), U8(119),
B(LdrContextSlot), R(1), U8(9), R(11),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(11),
- B(JumpIfFalse), U8(71),
+ B(TestEqualStrict), R(11), U8(19),
+ B(JumpIfFalse), U8(72),
B(LdaContextSlot), R(1), U8(11),
B(TypeOf),
B(Star), R(11),
B(LdaConstant), U8(13),
- B(TestEqualStrict), R(11),
+ B(TestEqualStrict), R(11), U8(20),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(129),
@@ -508,10 +508,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(11), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(10), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(8),
- B(JumpIfTrue), U8(10),
+ B(TestEqualStrict), R(8), U8(0),
+ B(JumpIfTrue), U8(11),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(8),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(17),
B(Jump), U8(28),
B(PopContext), R(1),
@@ -547,19 +547,19 @@ bytecodes: [
B(CallRuntime), U16(Runtime::k_GeneratorClose), R(8), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(7), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(5),
- B(JumpIfTrue), U8(28),
+ B(TestEqualStrict), R(5), U8(0),
+ B(JumpIfTrue), U8(32),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(5),
- B(JumpIfTrue), U8(25),
+ B(TestEqualStrict), R(5), U8(0),
+ B(JumpIfTrue), U8(28),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(5),
- B(JumpIfTrue), U8(22),
+ B(TestEqualStrict), R(5), U8(0),
+ B(JumpIfTrue), U8(24),
B(LdaSmi), U8(3),
- B(TestEqualStrict), R(5),
- B(JumpIfTrue), U8(19),
+ B(TestEqualStrict), R(5), U8(0),
+ B(JumpIfTrue), U8(20),
B(LdaSmi), U8(4),
- B(TestEqualStrict), R(5),
+ B(TestEqualStrict), R(5), U8(0),
B(JumpIfTrue), U8(16),
B(Jump), U8(17),
B(Ldar), R(6),
@@ -596,9 +596,9 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [45, 661, 667],
- [143, 423, 429],
- [146, 384, 386],
- [525, 537, 539],
+ [47, 677, 683],
+ [147, 432, 438],
+ [150, 392, 394],
+ [539, 551, 553],
]

Powered by Google App Engine
This is Rietveld 408576698