Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2286203004: Revert of Fix paint invalidation and painting for composited-scrolling input elements. (Closed)

Created:
4 years, 3 months ago by flackr
Modified:
4 years, 3 months ago
Reviewers:
bokan, chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix paint invalidation and painting for composited-scrolling input elements. (patchset #15 id:280001 of https://codereview.chromium.org/2271883002/ ) Reason for revert: Broke DisplayItemTest.DebugStringsExist on debug probably due to adding a new display item type without updating DisplayItem::typeAsDebugString. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20(dbg)/builds/4251/steps/blink_platform_unittests/logs/DisplayItemTest.DebugStringsExist Original issue's description: > Fix paint invalidation and painting for composited-scrolling input elements. > > In, particular, the following issues: > > 1. Paint invalidation missed cases when elements had "intrinsic scrollability", > in particular input elements. > 2. Invalidation of carets incorrectly included scrolling for composited input > elements. > 3. The DisplayItemClient must be distinct for case #2, because it paints into > a different GraphicsLayer than the rest of the LayoutBlock. > > BUG=635724 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/b1d694f3370e4b6d6e723382c086617f85c94e93 > Cr-Commit-Position: refs/heads/master@{#415013} TBR=bokan@chromium.org,pdr@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -490 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-composited-scrolling-container.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/selection/selection-in-composited-scrolling-container.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/selection/selection-in-composited-scrolling-container-expected.txt View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/selection/selection-in-non-composited-scrolling-container.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/selection/selection-in-non-composited-scrolling-container-expected.txt View 1 chunk +0 lines, -78 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.h View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 5 chunks +7 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
flackr
Created Revert of Fix paint invalidation and painting for composited-scrolling input elements.
4 years, 3 months ago (2016-08-29 17:00:20 UTC) #2
chrishtr
Fix is easy, will do that instead.
4 years, 3 months ago (2016-08-29 17:02:54 UTC) #4
flackr
4 years, 3 months ago (2016-08-29 17:07:10 UTC) #5
On 2016/08/29 at 17:02:54, chrishtr wrote:
> Fix is easy, will do that instead.

Thanks, closing.

Powered by Google App Engine
This is Rietveld 408576698