Issue 22861022: Revert "Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22861022: Revert "Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp." (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp." This reverts commit r16238 for not being able to use the defines outside of libv8 (i.e. in tests). Will reland the #define's in a build config header style. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16267

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -51 lines)			Patch
	M	tools/gyp/v8.gyp	View		9 chunks	+0 lines, -51 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

As discussed with Jakob offline yesterday, we can't get GYP to properly set these defines ...

7 years, 4 months ago (2013-08-22 07:27:16 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r16267.

Expand Messages | Collapse Messages