Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gyp/v8.gyp

Issue 22861022: Revert "Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index a7e89db682b73570f221b4664c29cfb6eec205a5..eccd7d263b40c58f569bd4c3aaa5e229746a3d60 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -689,10 +689,6 @@
}],
],
},
- 'defines': [
- 'V8_OS_LINUX=1',
- 'V8_OS_POSIX=1'
- ],
'sources': [ ### gcmole(os:linux) ###
'../../src/platform-linux.cc',
'../../src/platform-posix.cc'
@@ -710,29 +706,16 @@
['host_os=="mac"', {
'target_conditions': [
['_toolset=="host"', {
- 'defines': [
- 'V8_OS_BSD=1',
- 'V8_OS_MACOSX=1',
- 'V8_OS_POSIX=1'
- ],
'sources': [
'../../src/platform-macos.cc'
]
}, {
- 'defines': [
- 'V8_OS_LINUX=1',
- 'V8_OS_POSIX=1'
- ],
'sources': [
'../../src/platform-linux.cc'
]
}],
],
}, {
- 'defines': [
- 'V8_OS_LINUX=1',
- 'V8_OS_POSIX=1'
- ],
'sources': [
'../../src/platform-linux.cc'
]
@@ -741,11 +724,6 @@
},
],
['OS=="freebsd"', {
- 'defines': [
- 'V8_OS_BSD=1',
- 'V8_OS_FREEBSD=1',
- 'V8_OS_POSIX=1'
- ],
'link_settings': {
'libraries': [
'-L/usr/local/lib -lexecinfo',
@@ -757,11 +735,6 @@
}
],
['OS=="openbsd"', {
- 'defines': [
- 'V8_OS_BSD=1',
- 'V8_OS_OPENBSD=1',
- 'V8_OS_POSIX=1'
- ],
'link_settings': {
'libraries': [
'-L/usr/local/lib -lexecinfo',
@@ -773,11 +746,6 @@
}
],
['OS=="netbsd"', {
- 'defines': [
- 'V8_OS_BSD=1',
- 'V8_OS_NETBSD=1',
- 'V8_OS_POSIX=1'
- ],
'link_settings': {
'libraries': [
'-L/usr/pkg/lib -Wl,-R/usr/pkg/lib -lexecinfo',
@@ -789,10 +757,6 @@
}
],
['OS=="solaris"', {
- 'defines': [
- 'V8_OS_POSIX=1',
- 'V8_OS_SOLARIS=1'
- ],
'link_settings': {
'libraries': [
'-lsocket -lnsl',
@@ -804,11 +768,6 @@
}
],
['OS=="mac"', {
- 'defines': [
- 'V8_OS_BSD=1',
- 'V8_OS_MACOSX=1',
- 'V8_OS_POSIX=1'
- ],
'sources': [
'../../src/platform-macos.cc',
'../../src/platform-posix.cc'
@@ -825,18 +784,11 @@
},
'conditions': [
['build_env=="Cygwin"', {
- 'defines': [
- 'V8_OS_CYGWIN=1',
- 'V8_OS_POSIX=1'
- ],
'sources': [
'../../src/platform-cygwin.cc',
'../../src/platform-posix.cc',
],
}, {
- 'defines': [
- 'V8_OS_WIN=1'
- ],
'sources': [
'../../src/platform-win32.cc',
'../../src/win32-math.h',
@@ -848,9 +800,6 @@
'libraries': [ '-lwinmm', '-lws2_32' ],
},
}, {
- 'defines': [
- 'V8_OS_WIN=1'
- ],
'sources': [
'../../src/platform-win32.cc',
'../../src/win32-math.h',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698