Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 228603006: Cast: Log whether the video frame is a key frame in kVideoFrameEncoded (Closed)

Created:
6 years, 8 months ago by imcheng
Modified:
6 years, 8 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, jshin+watch_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Log whether the video frame is a key frame in kVideoFrameEncoded events. Rename InsertFrameEventWithSize to InsertEncodedFrameEvent. Now it takes an additional bool argument specifying whether the frame is key frame. Added an optional bool field key_frame in AggregatedFrameEvent proto. It is only set (in EncodingEventSubscriber) if there is a VIDEO_FRAME_ENCODED event. Also fix k{Audio,Video}FrameEncoded event to also log encoded frame size. BUG=359407 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263480

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : fix win x64 compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -50 lines) Patch
M media/cast/audio_sender/audio_encoder.cc View 1 2 2 chunks +15 lines, -2 lines 0 comments Download
M media/cast/logging/encoding_event_subscriber.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/cast/logging/encoding_event_subscriber_unittest.cc View 6 chunks +12 lines, -4 lines 0 comments Download
M media/cast/logging/logging_defines.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M media/cast/logging/logging_defines.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/logging_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/logging/logging_impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M media/cast/logging/logging_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/logging/logging_raw.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M media/cast/logging/logging_raw.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M media/cast/logging/logging_raw_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/logging/proto/raw_events.proto View 1 chunk +5 lines, -2 lines 0 comments Download
M media/cast/logging/simple_event_subscriber_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/logging/stats_event_subscriber_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
imcheng
6 years, 8 months ago (2014-04-08 18:09:18 UTC) #1
Alpha Left Google
lgtm
6 years, 8 months ago (2014-04-11 22:16:29 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 8 months ago (2014-04-11 22:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/228603006/20001
6 years, 8 months ago (2014-04-11 22:18:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-12 00:27:35 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=93920
6 years, 8 months ago (2014-04-12 00:27:36 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 8 months ago (2014-04-12 00:51:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/228603006/30001
6 years, 8 months ago (2014-04-12 00:52:37 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 05:17:40 UTC) #9
Message was sent while issue was closed.
Change committed as 263480

Powered by Google App Engine
This is Rietveld 408576698