Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: media/cast/logging/logging_raw_unittest.cc

Issue 228603006: Cast: Log whether the video frame is a key frame in kVideoFrameEncoded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win x64 compile Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/logging/logging_raw.cc ('k') | media/cast/logging/proto/raw_events.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/logging_raw_unittest.cc
diff --git a/media/cast/logging/logging_raw_unittest.cc b/media/cast/logging/logging_raw_unittest.cc
index 135aed5ea1b121a9a4792d53dd1cdf5d113190b8..25b522a9c68b0b91b8e214d3e252f409b86221aa 100644
--- a/media/cast/logging/logging_raw_unittest.cc
+++ b/media/cast/logging/logging_raw_unittest.cc
@@ -48,14 +48,15 @@ TEST_F(LoggingRawTest, FrameEvent) {
EXPECT_EQ(base::TimeDelta(), frame_events_[0].delay_delta);
}
-TEST_F(LoggingRawTest, FrameEventWithSize) {
+TEST_F(LoggingRawTest, EncodedFrameEvent) {
CastLoggingEvent event_type = kVideoFrameEncoded;
uint32 frame_id = 456u;
RtpTimestamp rtp_timestamp = 123u;
base::TimeTicks timestamp = base::TimeTicks();
int size = 1024;
- raw_.InsertFrameEventWithSize(timestamp, event_type, rtp_timestamp, frame_id,
- size);
+ bool key_frame = true;
+ raw_.InsertEncodedFrameEvent(timestamp, event_type, rtp_timestamp, frame_id,
+ size, key_frame);
event_subscriber_.GetPacketEventsAndReset(&packet_events_);
EXPECT_TRUE(packet_events_.empty());
@@ -71,6 +72,7 @@ TEST_F(LoggingRawTest, FrameEventWithSize) {
EXPECT_EQ(timestamp, frame_events_[0].timestamp);
EXPECT_EQ(event_type, frame_events_[0].type);
EXPECT_EQ(base::TimeDelta(), frame_events_[0].delay_delta);
+ EXPECT_EQ(key_frame, frame_events_[0].key_frame);
}
TEST_F(LoggingRawTest, FrameEventWithDelay) {
« no previous file with comments | « media/cast/logging/logging_raw.cc ('k') | media/cast/logging/proto/raw_events.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698