Password bubble: Move WebContents completely into the UI controller.

Password bubble: Move WebContents completely into the UI controller.

The model shouldn't know about WebContents. I think.

BUG=261628

[Mike West, 2014-04-08 14:54:56]

For our discussion tomorrow, Markus: I don't think the Model should know about
WebContents. Should it? Am I missing the point entirely? :)

vabr@: FYI.

-mike

[Mike West, 2014-04-09 18:37:23]

On 2014/04/08 14:54:56, Mike West wrote:
> For our discussion tomorrow, Markus: I don't think the Model should know about
> WebContents. Should it? Am I missing the point entirely? :)
> 
> vabr@: FYI.
> 
> -mike

Ping!

[markusheintz_, 2014-04-10 13:26:31]

https://codereview.chromium.org/228603003/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_bubble_model.h (right):

https://codereview.chromium.org/228603003/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_bubble_model.h:22:
ManagePasswordsBubbleUIController* ui_controller);
Instead of passing the UI controller to the model you could also define a model
observer. Then the model must not know anything about the controller and is easy
to test.

This means on the end only the controller knows about the model and the view but
the other don't know about the controller.

Given that the model will only be used by the controller and all belongs
together. I guess that is also ok.

[markusheintz_, 2014-04-29 07:52:38]

On 2014/04/10 13:26:31, markusheintz_ wrote:
>
https://codereview.chromium.org/228603003/diff/1/chrome/browser/ui/passwords/...
> File chrome/browser/ui/passwords/manage_passwords_bubble_model.h (right):
> 
>
https://codereview.chromium.org/228603003/diff/1/chrome/browser/ui/passwords/...
> chrome/browser/ui/passwords/manage_passwords_bubble_model.h:22:
> ManagePasswordsBubbleUIController* ui_controller);
> Instead of passing the UI controller to the model you could also define a
model
> observer. Then the model must not know anything about the controller and is
easy
> to test.
> 
> This means on the end only the controller knows about the model and the view
but
> the other don't know about the controller.
> 
> Given that the model will only be used by the controller and all belongs
> together. I guess that is also ok.

Should I take another look at this CL?

[Mike West, 2014-04-29 07:56:04]

On 2014/04/29 07:52:38, markusheintz_ wrote:
> On 2014/04/10 13:26:31, markusheintz_ wrote:
> >
>
https://codereview.chromium.org/228603003/diff/1/chrome/browser/ui/passwords/...
> > File chrome/browser/ui/passwords/manage_passwords_bubble_model.h (right):
> > 
> >
>
https://codereview.chromium.org/228603003/diff/1/chrome/browser/ui/passwords/...
> > chrome/browser/ui/passwords/manage_passwords_bubble_model.h:22:
> > ManagePasswordsBubbleUIController* ui_controller);
> > Instead of passing the UI controller to the model you could also define a
> model
> > observer. Then the model must not know anything about the controller and is
> easy
> > to test.
> > 
> > This means on the end only the controller knows about the model and the view
> but
> > the other don't know about the controller.
> > 
> > Given that the model will only be used by the controller and all belongs
> > together. I guess that is also ok.
> 
> Should I take another look at this CL?

No, it's been obsoleted by other CLs. Thanks!