Password bubble: Move WebContents completely into the UI controller.

chrome/browser/ui/passwords/manage_passwords_bubble_model.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 
+#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
 #include "components/autofill/core/common/password_form.h"
-#include "content/public/browser/web_contents_observer.h"
 
 class ManagePasswordsIconController;
 
 namespace content {
 class WebContents;
 }
 
 // This model provides data for the ManagePasswordsBubble and controls the
 // password management actions.
-class ManagePasswordsBubbleModel : public content::WebContentsObserver {
+class ManagePasswordsBubbleModel {
  public:
-  explicit ManagePasswordsBubbleModel(content::WebContents* web_contents);
+  explicit ManagePasswordsBubbleModel(
+      ManagePasswordsBubbleUIController* ui_controller);

[markusheintz_, 2014/04/10 13:26:31]

Instead of passing the UI controller to the model you could also define a model
observer. Then the model must not know anything about the controller and is easy
to test.

This means on the end only the controller knows about the model and the view but
the other don't know about the controller.

Given that the model will only be used by the controller and all belongs
together. I guess that is also ok.

   virtual ~ManagePasswordsBubbleModel();
 
   enum ManagePasswordsBubbleState {
     PASSWORD_TO_BE_SAVED,
     MANAGE_PASSWORDS_AFTER_SAVING,
     MANAGE_PASSWORDS,
     NEVER_SAVE_PASSWORDS,
   };
 
   enum PasswordAction { REMOVE_PASSWORD, ADD_PASSWORD };
@@ skipping 23 matching lines @@
   void DeleteFromBestMatches(autofill::PasswordForm password_form);
 
   ManagePasswordsBubbleState manage_passwords_bubble_state() {
     return manage_passwords_bubble_state_;
   }
 
   bool WaitingToSavePassword() {
     return manage_passwords_bubble_state() == PASSWORD_TO_BE_SAVED;
   }
 
-  bool password_submitted() { return password_submitted_; }
+  bool password_submitted() { return ui_controller_->password_submitted(); }
   const base::string16& title() { return title_; }
   const autofill::PasswordForm& pending_credentials() {
     return pending_credentials_;
   }
   const autofill::PasswordFormMap& best_matches() { return best_matches_; }
   const base::string16& manage_link() { return manage_link_; }
 
  private:
-  // content::WebContentsObserver
-  virtual void WebContentsDestroyed(
-      content::WebContents* web_contents) OVERRIDE;
-
-  content::WebContents* web_contents_;
+  ManagePasswordsBubbleUIController* ui_controller_;
   ManagePasswordsBubbleState manage_passwords_bubble_state_;
   bool password_submitted_;
   base::string16 title_;
   autofill::PasswordForm pending_credentials_;
   autofill::PasswordFormMap best_matches_;
   base::string16 manage_link_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_