Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: base/test/gtest_util.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_parser_unittest.cc ('k') | chrome/test/base/javascript_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/gtest_util.cc
diff --git a/base/test/gtest_util.cc b/base/test/gtest_util.cc
index 50ac9e6ff6cd0fc59be22a50a750ee9004ff0811..5432c4ac112d60237d477bb38da13a3bc2a9a78a 100644
--- a/base/test/gtest_util.cc
+++ b/base/test/gtest_util.cc
@@ -49,7 +49,7 @@ bool WriteCompiledInTestsToFile(const FilePath& path) {
ListValue root;
for (size_t i = 0; i < tests.size(); ++i) {
- std::unique_ptr<class base::DictionaryValue> test_info(new DictionaryValue);
+ std::unique_ptr<DictionaryValue> test_info(new DictionaryValue);
test_info->SetString("test_case_name", tests[i].test_case_name);
test_info->SetString("test_name", tests[i].test_name);
test_info->SetString("file", tests[i].file);
« no previous file with comments | « base/json/json_parser_unittest.cc ('k') | chrome/test/base/javascript_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698