Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: base/json/json_parser_unittest.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_parser.cc ('k') | base/test/gtest_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_parser_unittest.cc
diff --git a/base/json/json_parser_unittest.cc b/base/json/json_parser_unittest.cc
index 30255ca46126dd89ad0e8471f67eaa4d26bcf39a..542cc68412e712d045f0c4313bcb93f8c446c0a3 100644
--- a/base/json/json_parser_unittest.cc
+++ b/base/json/json_parser_unittest.cc
@@ -105,7 +105,7 @@ TEST_F(JSONParserTest, ConsumeLiterals) {
// Literal |false|.
input = "false,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeLiteral());
+ value = parser->ConsumeLiteral();
EXPECT_EQ('e', *parser->pos_);
TestLastThree(parser.get());
@@ -117,7 +117,7 @@ TEST_F(JSONParserTest, ConsumeLiterals) {
// Literal |null|.
input = "null,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeLiteral());
+ value = parser->ConsumeLiteral();
EXPECT_EQ('l', *parser->pos_);
TestLastThree(parser.get());
@@ -143,7 +143,7 @@ TEST_F(JSONParserTest, ConsumeNumbers) {
// Negative integer.
input = "-1234,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeNumber());
+ value = parser->ConsumeNumber();
EXPECT_EQ('4', *parser->pos_);
TestLastThree(parser.get());
@@ -155,7 +155,7 @@ TEST_F(JSONParserTest, ConsumeNumbers) {
// Double.
input = "12.34,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeNumber());
+ value = parser->ConsumeNumber();
EXPECT_EQ('4', *parser->pos_);
TestLastThree(parser.get());
@@ -168,7 +168,7 @@ TEST_F(JSONParserTest, ConsumeNumbers) {
// Scientific.
input = "42e3,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeNumber());
+ value = parser->ConsumeNumber();
EXPECT_EQ('3', *parser->pos_);
TestLastThree(parser.get());
@@ -180,7 +180,7 @@ TEST_F(JSONParserTest, ConsumeNumbers) {
// Negative scientific.
input = "314159e-5,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeNumber());
+ value = parser->ConsumeNumber();
EXPECT_EQ('5', *parser->pos_);
TestLastThree(parser.get());
@@ -192,7 +192,7 @@ TEST_F(JSONParserTest, ConsumeNumbers) {
// Positive scientific.
input = "0.42e+3,|";
parser.reset(NewTestParser(input));
- value.reset(parser->ConsumeNumber());
+ value = parser->ConsumeNumber();
EXPECT_EQ('3', *parser->pos_);
TestLastThree(parser.get());
« no previous file with comments | « base/json/json_parser.cc ('k') | base/test/gtest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698