Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2285913002: Fix small error in relative bounds calc for Chrome OS only. (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
aboxhall
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix small error in relative bounds calc for Chrome OS only. The new relative bounds calculation code walks up the hierarchy applying offsets and transforms to convert from the relative coordinates of one object to the global screen coordinates. This was broken for an obscure case where one of the parents of a node has width and height zero because we were calling ComputeLocalNodeBounds on every ancestor, when it was intended to only be called on the node you're trying to get the bounds of. BUG=641574 Committed: https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c Cr-Commit-Position: refs/heads/master@{#415461}

Patch Set 1 #

Patch Set 2 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/automation/sites/location2.html View 1 1 chunk +7 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/automation/tests/tabs/location2.html View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dmazzoni
4 years, 3 months ago (2016-08-26 22:29:28 UTC) #2
aboxhall
lgtm Is it possible/simple to write a test for this?
4 years, 3 months ago (2016-08-26 22:48:22 UTC) #3
dmazzoni
Regression test added!
4 years, 3 months ago (2016-08-30 21:02:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285913002/20001
4 years, 3 months ago (2016-08-30 21:03:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 22:27:58 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:29:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c
Cr-Commit-Position: refs/heads/master@{#415461}

Powered by Google App Engine
This is Rietveld 408576698