chrome/renderer/extensions/automation_internal_custom_bindings.cc - Issue 2285913002: Fix small error in relative bounds calc for Chrome OS only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/automation_internal_custom_bindings.cc

Issue 2285913002: Fix small error in relative bounds calc for Chrome OS only. (Closed)

Patch Set: Add regression test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/automation_internal_custom_bindings.cc

diff --git a/chrome/renderer/extensions/automation_internal_custom_bindings.cc b/chrome/renderer/extensions/automation_internal_custom_bindings.cc

index 6fc8560df45170bede51497bc66601b52b015bcf..78e51c92e7b73870958995306070e937e65cfac3 100644

--- a/chrome/renderer/extensions/automation_internal_custom_bindings.cc

+++ b/chrome/renderer/extensions/automation_internal_custom_bindings.cc

@@ -134,7 +134,7 @@ static gfx::Rect ComputeGlobalNodeBounds(TreeCache* cache, ui::AXNode* node) {

if (!container || container == node)

break;

- gfx::RectF container_bounds = ComputeLocalNodeBounds(cache, container);

+ gfx::RectF container_bounds = container->data().location;

bounds.Offset(container_bounds.x(), container_bounds.y());

int scroll_x = 0;