Add a CustomSchemeHandler runtime flag to remove ENABLE(CUSTOM_SCHEME_HANDLER)

Add a CustomSchemeHandler runtime flag to remove ENABLE(CUSTOM_SCHEME_HANDLER).

As a step to remove #ifdef, this cl add a new runtime flag(CustomSchemeHandler), then it removes #if ENABLE(CUSTOM_SCHEME_HANDLER).

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164740

[gyuyoung-inactive, 2013-08-22 01:11:16]

As mentioned in https://codereview.chromium.org/22871006/#msg8, this cl removes
ENABLE(CUSTOM_SCHEME_HANDLER).

[abarth-chromium, 2013-08-22 17:19:58]

You've removed the ENABLE(CUSTOM_SCHEME_HANDLER) macro from CPP, but you've left
it in the IDL file:

http://src.chromium.org/viewvc/blink/trunk/Source/modules/navigatorcontentuti...

Instead what you should do is add a runtime flag and replace
CUSTOM_SCHEME_HANDLER with the runtime flag in the appropriate places.

I'm starting to get frustrated with these CLs.  You don't seem to understand
what we're trying to accomplish.  I feel like you're waiting my time with these
CLs.

not lgtm

https://codereview.chromium.org/22859043/diff/1/Source/core/features.gypi
File Source/core/features.gypi (left):

https://codereview.chromium.org/22859043/diff/1/Source/core/features.gypi#old...
Source/core/features.gypi:38: 'ENABLE_CUSTOM_SCHEME_HANDLER=0',
Notice that this ifdef is disabled.

[gyuyoung-inactive, 2013-08-23 07:42:45]

On 2013/08/22 17:19:58, abarth wrote:
> You've removed the ENABLE(CUSTOM_SCHEME_HANDLER) macro from CPP, but you've
left
> it in the IDL file:
> 
>
http://src.chromium.org/viewvc/blink/trunk/Source/modules/navigatorcontentuti...
> 
> Instead what you should do is add a runtime flag and replace
> CUSTOM_SCHEME_HANDLER with the runtime flag in the appropriate places.
> 
> I'm starting to get frustrated with these CLs.  You don't seem to understand
> what we're trying to accomplish.  I feel like you're waiting my time with
these
> CLs.
> 
> not lgtm

Frankly, it may be true I have misunderstanding about it. I'm sorry about it. I
will take a look this feature further on this weekend. Then, I will talk with
you again.

Thanks.

[gyuyoung-inactive, 2014-01-06 07:05:16]

Abarth, could you take a look this again ? I update this patch.

[gyuyoung-inactive, 2014-01-06 07:09:06]

https://codereview.chromium.org/22859043/diff/35001/LayoutTests/fast/dom/unre...
File LayoutTests/fast/dom/unregister-protocol-handler-expected.txt (left):

https://codereview.chromium.org/22859043/diff/35001/LayoutTests/fast/dom/unre...
LayoutTests/fast/dom/unregister-protocol-handler-expected.txt:27: Fail: Invalid
url "" allowed.
This expected result will be updated on issue 22871006 after landing this cl.

https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.idl (right):

https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
Source/modules/navigatorcontentutils/NavigatorContentUtils.idl:24:
[RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException]
DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);
I'm not sure if *," is a correct way to adjust multiple condition. Do you know
how to adjust multiple flags together ? 
For now, it looks this is enabled by both NavigatorContentUtils and
CustomSchemeHandler.

[abarth-chromium, 2014-01-06 21:49:46]

https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.idl (right):

https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
Source/modules/navigatorcontentutils/NavigatorContentUtils.idl:24:
[RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException]
DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);
On 2014/01/06 07:09:06, gyuyoung wrote:
> I'm not sure if *," is a correct way to adjust multiple condition. Do you know
> how to adjust multiple flags together ? 
> For now, it looks this is enabled by both NavigatorContentUtils and
> CustomSchemeHandler.

I think you write:

RuntimeEnabled=NavigatorContentUtils&CustomSchemeHandler,

but you should test and find out.

[gyuyoung-inactive, 2014-01-07 00:05:57]

https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.idl (right):

https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
Source/modules/navigatorcontentutils/NavigatorContentUtils.idl:24:
[RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException]
DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);
On 2014/01/06 21:49:46, abarth wrote:
> On 2014/01/06 07:09:06, gyuyoung wrote:
> > I'm not sure if *," is a correct way to adjust multiple condition. Do you
know
> > how to adjust multiple flags together ? 
> > For now, it looks this is enabled by both NavigatorContentUtils and
> > CustomSchemeHandler.
> 
> I think you write:
> 
> RuntimeEnabled=NavigatorContentUtils&CustomSchemeHandler,
> 
> but you should test and find out.

It looks *RuntimeEnabled* doesn't support '&' operator for multiple flags. Do
you think can I change it to support '&' ?

[gyuyoung-inactive, 2014-01-07 04:22:15]

On 2014/01/07 00:05:57, gyuyoung wrote:
>
https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
> File Source/modules/navigatorcontentutils/NavigatorContentUtils.idl (right):
> 
>
https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
> Source/modules/navigatorcontentutils/NavigatorContentUtils.idl:24:
> [RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException]
> DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);
> On 2014/01/06 21:49:46, abarth wrote:
> > On 2014/01/06 07:09:06, gyuyoung wrote:
> > > I'm not sure if *," is a correct way to adjust multiple condition. Do you
> know
> > > how to adjust multiple flags together ? 
> > > For now, it looks this is enabled by both NavigatorContentUtils and
> > > CustomSchemeHandler.
> > 
> > I think you write:
> > 
> > RuntimeEnabled=NavigatorContentUtils&CustomSchemeHandler,
> > 
> > but you should test and find out.
> 
> It looks *RuntimeEnabled* doesn't support '&' operator for multiple flags. Do
> you think can I change it to support '&' ?

Abarth, I make a try to support multiple flags by RuntimeEnabled.
https://codereview.chromium.org/125533003/

I wonder how do you think about this. If there is any reason not to modify it,
please let me know.

[gyuyoung-inactive, 2014-01-07 08:55:43]

On 2014/01/07 04:22:15, gyuyoung wrote:
> On 2014/01/07 00:05:57, gyuyoung wrote:
> >
>
https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
> > File Source/modules/navigatorcontentutils/NavigatorContentUtils.idl (right):
> > 
> >
>
https://codereview.chromium.org/22859043/diff/35001/Source/modules/navigatorc...
> > Source/modules/navigatorcontentutils/NavigatorContentUtils.idl:24:
> > [RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException]
> > DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);
> > On 2014/01/06 21:49:46, abarth wrote:
> > > On 2014/01/06 07:09:06, gyuyoung wrote:
> > > > I'm not sure if *," is a correct way to adjust multiple condition. Do
you
> > know
> > > > how to adjust multiple flags together ? 
> > > > For now, it looks this is enabled by both NavigatorContentUtils and
> > > > CustomSchemeHandler.
> > > 
> > > I think you write:
> > > 
> > > RuntimeEnabled=NavigatorContentUtils&CustomSchemeHandler,
> > > 
> > > but you should test and find out.
> > 
> > It looks *RuntimeEnabled* doesn't support '&' operator for multiple flags.
Do
> > you think can I change it to support '&' ?
> 
> Abarth, I make a try to support multiple flags by RuntimeEnabled.
> https://codereview.chromium.org/125533003/
> 
> I wonder how do you think about this. If there is any reason not to modify it,
> please let me know.

The *depends_on* can support my need. Thus, we don't need to use '&' in this
case.

[abarth-chromium, 2014-01-09 00:22:41]

lgtm

Looks great!  Thanks for iterating on this CL.

[commit-bot: I haz the power, 2014-01-09 00:22:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/22859043/165001

[gyuyoung-inactive, 2014-01-09 02:09:41]

On 2014/01/09 00:22:41, abarth wrote:
> lgtm
> 
> Looks great!  Thanks for iterating on this CL.

According to custom scheme handler is opened as *experimental*,
fast/dom/navigator-detached-no-crash-expected.txt needs to be updated as well.
Updated it.

[commit-bot: I haz the power, 2014-01-09 02:10:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/22859043/295001

[commit-bot: I haz the power, 2014-01-09 04:16:34]

Change committed as 164740