Source/modules/navigatorcontentutils/NavigatorContentUtils.idl - Issue 22859043: Add a CustomSchemeHandler runtime flag to remove ENABLE(CUSTOM_SCHEME_HANDLER)

Side by Side Diff: Source/modules/navigatorcontentutils/NavigatorContentUtils.idl

Issue 22859043: Add a CustomSchemeHandler runtime flag to remove ENABLE(CUSTOM_SCHEME_HANDLER) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/unregister-protocol-handler-expected.txt ('K') | « Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp ('k') | Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)	2 Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)

3 Copyright (C) 2012, Samsung Electronics. All rights reserved.	3 Copyright (C) 2012, Samsung Electronics. All rights reserved.

4	4

5 This library is free software; you can redistribute it and/or	5 This library is free software; you can redistribute it and/or

6 modify it under the terms of the GNU Library General Public	6 modify it under the terms of the GNU Library General Public

7 License as published by the Free Software Foundation; either	7 License as published by the Free Software Foundation; either

8 version 2 of the License, or (at your option) any later version.	8 version 2 of the License, or (at your option) any later version.

9	9

10 This library is distributed in the hope that it will be useful,	10 This library is distributed in the hope that it will be useful,

11 but WITHOUT ANY WARRANTY; without even the implied warranty of	11 but WITHOUT ANY WARRANTY; without even the implied warranty of

12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU	12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

13 Library General Public License for more details.	13 Library General Public License for more details.

14	14

15 You should have received a copy of the GNU Library General Public License	15 You should have received a copy of the GNU Library General Public License

16 along with this library; see the file COPYING.LIB. If not, write to	16 along with this library; see the file COPYING.LIB. If not, write to

17 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,	17 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,

18 Boston, MA 02110-1301, USA.	18 Boston, MA 02110-1301, USA.

19 */	19 */

20	20

21 // http://www.w3.org/TR/html5/system-state-and-capabilities.html#custom-handlers	21 // http://www.w3.org/TR/html5/system-state-and-capabilities.html#custom-handlers

22 partial interface Navigator {	22 partial interface Navigator {

23 [RuntimeEnabled=NavigatorContentUtils, RaisesException] void registerProtoco lHandler(DOMString scheme, DOMString url, DOMString title);	23 [RuntimeEnabled=NavigatorContentUtils, RaisesException] void registerProtoco lHandler(DOMString scheme, DOMString url, DOMString title);

24 [RuntimeEnabled=NavigatorContentUtils, Conditional=CUSTOM_SCHEME_HANDLER, Ra isesException] DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);	24 [RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException] DOMString isProtocolHandlerRegistered(DOMString scheme, DOMString url);
	gyuyoung-inactive 2014/01/06 07:09:06 I'm not sure if ," is a correct way to adjust mul I'm not sure if ," is a correct way to adjust multiple condition. Do you know how to adjust multiple flags together ? For now, it looks this is enabled by both NavigatorContentUtils and CustomSchemeHandler. abarth-chromium 2014/01/06 21:49:46 I think you write: RuntimeEnabled=NavigatorConten Show quoted text On 2014/01/06 07:09:06, gyuyoung wrote: > I'm not sure if ," is a correct way to adjust multiple condition. Do you know > how to adjust multiple flags together ? > For now, it looks this is enabled by both NavigatorContentUtils and > CustomSchemeHandler. I think you write: RuntimeEnabled=NavigatorContentUtils&CustomSchemeHandler, but you should test and find out. gyuyoung-inactive* 2014/01/07 00:05:58 It looks RuntimeEnabled doesn't support '&' oper Show quoted text On 2014/01/06 21:49:46, abarth wrote: > On 2014/01/06 07:09:06, gyuyoung wrote: > > I'm not sure if ," is a correct way to adjust multiple condition. Do you know > > how to adjust multiple flags together ? > > For now, it looks this is enabled by both NavigatorContentUtils and > > CustomSchemeHandler. > > I think you write: > > RuntimeEnabled=NavigatorContentUtils&CustomSchemeHandler, > > but you should test and find out. It looks RuntimeEnabled* doesn't support '&' operator for multiple flags. Do you think can I change it to support '&' ?
25 [RuntimeEnabled=NavigatorContentUtils, Conditional=CUSTOM_SCHEME_HANDLER, Ra isesException] void unregisterProtocolHandler(DOMString scheme, DOMString url);	25 [RuntimeEnabled=NavigatorContentUtils, CustomSchemeHandler, RaisesException] void unregisterProtocolHandler(DOMString scheme, DOMString url);

26 };	26 };

27	27

OLD	NEW