Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2285843002: Clean up nits in settings_utils_linux.cc. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up nits in settings_utils_linux.cc. Also don't bother compiling it on ChromeOS at all. Committed: https://crrev.com/f38dea644a694f7a587279b63faca1975ca289d2 Cr-Commit-Position: refs/heads/master@{#414781}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M chrome/browser/ui/webui/settings_utils_linux.cc View 5 chunks +12 lines, -15 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
Lei Zhang
4 years, 3 months ago (2016-08-26 19:15:23 UTC) #6
tommycli
lgtm https://codereview.chromium.org/2285843002/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/2285843002/diff/1/chrome/chrome_browser_ui.gypi#newcode1360 chrome/chrome_browser_ui.gypi:1360: 'chrome_browser_ui_desktop_sources': [ And there's already a filter for ...
4 years, 3 months ago (2016-08-26 19:28:16 UTC) #7
Lei Zhang
https://codereview.chromium.org/2285843002/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/2285843002/diff/1/chrome/chrome_browser_ui.gypi#newcode1360 chrome/chrome_browser_ui.gypi:1360: 'chrome_browser_ui_desktop_sources': [ On 2016/08/26 19:28:16, tommycli wrote: > And ...
4 years, 3 months ago (2016-08-26 19:34:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285843002/1
4 years, 3 months ago (2016-08-26 19:35:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 19:40:56 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:42:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f38dea644a694f7a587279b63faca1975ca289d2
Cr-Commit-Position: refs/heads/master@{#414781}

Powered by Google App Engine
This is Rietveld 408576698