Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/chrome_browser_ui.gypi

Issue 2285843002: Clean up nits in settings_utils_linux.cc. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings_utils_linux.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # There are two sections of sources: 7 # There are two sections of sources:
8 # * "Platform"-based sources (OS, toolkit, etc.) 8 # * "Platform"-based sources (OS, toolkit, etc.)
9 # * Feature/directory-based sources (e.g., history, printing) 9 # * Feature/directory-based sources (e.g., history, printing)
10 10
(...skipping 1339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1350 'browser/ui/cocoa/website_settings/website_settings_utils_cocoa.mm', 1350 'browser/ui/cocoa/website_settings/website_settings_utils_cocoa.mm',
1351 'browser/ui/cocoa/window_size_autosaver.h', 1351 'browser/ui/cocoa/window_size_autosaver.h',
1352 'browser/ui/cocoa/window_size_autosaver.mm', 1352 'browser/ui/cocoa/window_size_autosaver.mm',
1353 # TODO(estade): this class should be deleted in favor of a combobox model. 1353 # TODO(estade): this class should be deleted in favor of a combobox model.
1354 # See crbug.com/590850 1354 # See crbug.com/590850
1355 'browser/ui/content_settings/content_setting_media_menu_model.cc', 1355 'browser/ui/content_settings/content_setting_media_menu_model.cc',
1356 'browser/ui/content_settings/content_setting_media_menu_model.h', 1356 'browser/ui/content_settings/content_setting_media_menu_model.h',
1357 'browser/ui/proximity_auth/proximity_auth_error_bubble_stub.cc', 1357 'browser/ui/proximity_auth/proximity_auth_error_bubble_stub.cc',
1358 ], 1358 ],
1359 # Files used only on desktop systems (not iOS, Android, ChromeOS). 1359 # Files used only on desktop systems (not iOS, Android, ChromeOS).
1360 'chrome_browser_ui_desktop_sources': [ 1360 'chrome_browser_ui_desktop_sources': [
tommycli 2016/08/26 19:28:16 And there's already a filter for _linux _mac and _
Lei Zhang 2016/08/26 19:34:41 Yep. It's only the linuxiness that's in question h
1361 'browser/ui/avatar_button_error_controller.h', 1361 'browser/ui/avatar_button_error_controller.h',
1362 'browser/ui/avatar_button_error_controller.cc', 1362 'browser/ui/avatar_button_error_controller.cc',
1363 'browser/ui/avatar_button_error_controller_delegate.h', 1363 'browser/ui/avatar_button_error_controller_delegate.h',
1364 'browser/ui/startup/default_browser_infobar_delegate.cc', 1364 'browser/ui/startup/default_browser_infobar_delegate.cc',
1365 'browser/ui/startup/default_browser_infobar_delegate.h', 1365 'browser/ui/startup/default_browser_infobar_delegate.h',
1366 'browser/ui/startup/default_browser_prompt.cc', 1366 'browser/ui/startup/default_browser_prompt.cc',
1367 'browser/ui/startup/default_browser_prompt.h', 1367 'browser/ui/startup/default_browser_prompt.h',
1368 'browser/ui/startup/default_browser_prompt_win.cc', 1368 'browser/ui/startup/default_browser_prompt_win.cc',
1369 'browser/ui/sync/one_click_signin_links_delegate.h', 1369 'browser/ui/sync/one_click_signin_links_delegate.h',
1370 'browser/ui/sync/one_click_signin_links_delegate_impl.cc', 1370 'browser/ui/sync/one_click_signin_links_delegate_impl.cc',
1371 'browser/ui/sync/one_click_signin_links_delegate_impl.h', 1371 'browser/ui/sync/one_click_signin_links_delegate_impl.h',
1372 'browser/ui/sync/one_click_signin_sync_observer.cc', 1372 'browser/ui/sync/one_click_signin_sync_observer.cc',
1373 'browser/ui/sync/one_click_signin_sync_observer.h', 1373 'browser/ui/sync/one_click_signin_sync_observer.h',
1374 'browser/ui/sync/one_click_signin_sync_starter.cc', 1374 'browser/ui/sync/one_click_signin_sync_starter.cc',
1375 'browser/ui/sync/one_click_signin_sync_starter.h', 1375 'browser/ui/sync/one_click_signin_sync_starter.h',
1376 'browser/ui/views/frame/avatar_button_manager.cc', 1376 'browser/ui/views/frame/avatar_button_manager.cc',
1377 'browser/ui/views/frame/avatar_button_manager.h', 1377 'browser/ui/views/frame/avatar_button_manager.h',
1378 'browser/ui/views/profiles/avatar_button_delegate.h', 1378 'browser/ui/views/profiles/avatar_button_delegate.h',
1379 'browser/ui/views/profiles/avatar_button_style.h', 1379 'browser/ui/views/profiles/avatar_button_style.h',
1380 'browser/ui/views/profiles/new_avatar_button.cc', 1380 'browser/ui/views/profiles/new_avatar_button.cc',
1381 'browser/ui/views/profiles/new_avatar_button.h', 1381 'browser/ui/views/profiles/new_avatar_button.h',
1382 'browser/ui/webui/app_launcher_page_ui.cc', 1382 'browser/ui/webui/app_launcher_page_ui.cc',
1383 'browser/ui/webui/app_launcher_page_ui.h', 1383 'browser/ui/webui/app_launcher_page_ui.h',
1384 'browser/ui/webui/settings/settings_default_browser_handler.cc', 1384 'browser/ui/webui/settings/settings_default_browser_handler.cc',
1385 'browser/ui/webui/settings/settings_default_browser_handler.h', 1385 'browser/ui/webui/settings/settings_default_browser_handler.h',
1386 'browser/ui/webui/settings/system_handler.cc', 1386 'browser/ui/webui/settings/system_handler.cc',
1387 'browser/ui/webui/settings/system_handler.h', 1387 'browser/ui/webui/settings/system_handler.h',
1388 'browser/ui/webui/settings_utils_linux.cc',
1389 'browser/ui/webui/settings_utils_mac.mm',
1390 'browser/ui/webui/settings_utils_win.cc',
1388 'browser/ui/webui/signin/inline_login_handler.cc', 1391 'browser/ui/webui/signin/inline_login_handler.cc',
1389 'browser/ui/webui/signin/inline_login_handler.h', 1392 'browser/ui/webui/signin/inline_login_handler.h',
1390 'browser/ui/webui/signin/inline_login_handler_impl.cc', 1393 'browser/ui/webui/signin/inline_login_handler_impl.cc',
1391 'browser/ui/webui/signin/inline_login_handler_impl.h', 1394 'browser/ui/webui/signin/inline_login_handler_impl.h',
1392 'browser/ui/webui/signin/inline_login_ui.cc', 1395 'browser/ui/webui/signin/inline_login_ui.cc',
1393 'browser/ui/webui/signin/inline_login_ui.h', 1396 'browser/ui/webui/signin/inline_login_ui.h',
1394 'browser/ui/webui/signin/md_user_manager_ui.cc', 1397 'browser/ui/webui/signin/md_user_manager_ui.cc',
1395 'browser/ui/webui/signin/md_user_manager_ui.h', 1398 'browser/ui/webui/signin/md_user_manager_ui.h',
1396 'browser/ui/webui/signin/signin_create_profile_handler.cc', 1399 'browser/ui/webui/signin/signin_create_profile_handler.cc',
1397 'browser/ui/webui/signin/signin_create_profile_handler.h', 1400 'browser/ui/webui/signin/signin_create_profile_handler.h',
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
2060 'browser/ui/webui/settings/settings_media_devices_selection_handler.cc', 2063 'browser/ui/webui/settings/settings_media_devices_selection_handler.cc',
2061 'browser/ui/webui/settings/settings_media_devices_selection_handler.h', 2064 'browser/ui/webui/settings/settings_media_devices_selection_handler.h',
2062 'browser/ui/webui/settings/settings_page_ui_handler.cc', 2065 'browser/ui/webui/settings/settings_page_ui_handler.cc',
2063 'browser/ui/webui/settings/settings_page_ui_handler.h', 2066 'browser/ui/webui/settings/settings_page_ui_handler.h',
2064 'browser/ui/webui/settings/settings_startup_pages_handler.cc', 2067 'browser/ui/webui/settings/settings_startup_pages_handler.cc',
2065 'browser/ui/webui/settings/settings_startup_pages_handler.h', 2068 'browser/ui/webui/settings/settings_startup_pages_handler.h',
2066 'browser/ui/webui/settings/site_settings_handler.cc', 2069 'browser/ui/webui/settings/site_settings_handler.cc',
2067 'browser/ui/webui/settings/site_settings_handler.h', 2070 'browser/ui/webui/settings/site_settings_handler.h',
2068 'browser/ui/webui/settings_utils.cc', 2071 'browser/ui/webui/settings_utils.cc',
2069 'browser/ui/webui/settings_utils.h', 2072 'browser/ui/webui/settings_utils.h',
2070 'browser/ui/webui/settings_utils_linux.cc',
2071 'browser/ui/webui/settings_utils_mac.mm',
2072 'browser/ui/webui/settings_utils_win.cc',
2073 'browser/ui/webui/signin/get_auth_frame.cc', 2073 'browser/ui/webui/signin/get_auth_frame.cc',
2074 'browser/ui/webui/signin/get_auth_frame.h', 2074 'browser/ui/webui/signin/get_auth_frame.h',
2075 'browser/ui/webui/signin/login_ui_service.cc', 2075 'browser/ui/webui/signin/login_ui_service.cc',
2076 'browser/ui/webui/signin/login_ui_service.h', 2076 'browser/ui/webui/signin/login_ui_service.h',
2077 'browser/ui/webui/signin/login_ui_service_factory.cc', 2077 'browser/ui/webui/signin/login_ui_service_factory.cc',
2078 'browser/ui/webui/signin/login_ui_service_factory.h', 2078 'browser/ui/webui/signin/login_ui_service_factory.h',
2079 'browser/ui/webui/signin/profile_signin_confirmation_dialog.cc', 2079 'browser/ui/webui/signin/profile_signin_confirmation_dialog.cc',
2080 'browser/ui/webui/signin/profile_signin_confirmation_dialog.h', 2080 'browser/ui/webui/signin/profile_signin_confirmation_dialog.h',
2081 'browser/ui/webui/signin/profile_signin_confirmation_ui.cc', 2081 'browser/ui/webui/signin/profile_signin_confirmation_ui.cc',
2082 'browser/ui/webui/signin/profile_signin_confirmation_ui.h', 2082 'browser/ui/webui/signin/profile_signin_confirmation_ui.h',
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
3334 ], 3334 ],
3335 'sources': [ 3335 'sources': [
3336 '<@(chrome_browser_ui_non_mobile_sources)', 3336 '<@(chrome_browser_ui_non_mobile_sources)',
3337 '<@(chrome_browser_ui_omnibox_non_mobile_sources)', 3337 '<@(chrome_browser_ui_omnibox_non_mobile_sources)',
3338 ], 3338 ],
3339 }], 3339 }],
3340 ], 3340 ],
3341 }, 3341 },
3342 ], 3342 ],
3343 } 3343 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/settings_utils_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698