Android: uses taskset when starting adb.

build/android/buildbot/bb_device_steps.py

Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 32438ae8fc47479a96b2d6d96e35ae133528cfc6..b4ff193fd4e3fb4973c2a362cc0fe6e53d0f3b3c 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -237,12 +237,13 @@ def SpawnLogcatMonitor():
   RunCmd(['sleep', '5'])
 
 def ProvisionDevices(options):
+  bb_annotations.PrintNamedStep('provision_devices')
+
   # Restart adb to work around bugs, sleep to wait for usb discovery.
   RunCmd(['adb', 'kill-server'])
-  RunCmd(['adb', 'start-server'])
+  RunCmd(['taskset', '-c', '0', 'adb', 'start-server'])
   RunCmd(['sleep', '1'])

[frankf, 2013/08/14 17:03:01]

All interactions with adb should go through android_commands.py. Let's use
RestartAdbServer() tehre.

[bulach, 2013/08/14 17:56:24]

hmm... I think this just emits the commands, it doesn't really run them?
ilevy?
I mean, we could potentially have a build/android/restart_adb_server.py that
then depends on pylib/android_commands.py if you prefer?

(also, please note this patch just adds the taskset, it doesn't add a new
dependency to adb..)

[frankf, 2013/08/14 18:05:44]

I'm not following. RunCmd here just runs that exact command. It's good to
centralize all knowledge of adb in android_commands.py and fix the issue there
(Otherwise someone might use RestartAdbServer which doesn't have CPU affinity)
There are existing calls to android_commands.py in this file (this is issue with
existing code not your changes)

On 2013/08/14 17:56:24, bulach wrote:

[bulach, 2013/08/14 18:09:59]

ahn, you're right! my confusion, I thought this would just "generate" the
commands rather than actually executing it.. new patch in a sec.

 
-  bb_annotations.PrintNamedStep('provision_devices')
   if options.reboot:
     RebootDevices()
   provision_cmd = ['build/android/provision_devices.py', '-t', options.target]