Android: uses taskset when starting adb.

build/android/buildbot/bb_device_steps.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import glob
 import multiprocessing
 import os
 import shutil
@@ skipping 219 matching lines @@
 def SpawnLogcatMonitor():
   shutil.rmtree(LOGCAT_DIR, ignore_errors=True)
   bb_utils.SpawnCmd([
       os.path.join(CHROME_SRC, 'build', 'android', 'adb_logcat_monitor.py'),
       LOGCAT_DIR])
 
   # Wait for logcat_monitor to pull existing logcat
   RunCmd(['sleep', '5'])
 
 def ProvisionDevices(options):
+  bb_annotations.PrintNamedStep('provision_devices')
+
   # Restart adb to work around bugs, sleep to wait for usb discovery.
   RunCmd(['adb', 'kill-server'])
-  RunCmd(['adb', 'start-server'])
+  RunCmd(['taskset', '-c', '0', 'adb', 'start-server'])
   RunCmd(['sleep', '1'])

[frankf, 2013/08/14 17:03:01]

All interactions with adb should go through android_commands.py. Let's use
RestartAdbServer() tehre.

[bulach, 2013/08/14 17:56:24]

hmm... I think this just emits the commands, it doesn't really run them?
ilevy?
I mean, we could potentially have a build/android/restart_adb_server.py that
then depends on pylib/android_commands.py if you prefer?

(also, please note this patch just adds the taskset, it doesn't add a new
dependency to adb..)

[frankf, 2013/08/14 18:05:44]

I'm not following. RunCmd here just runs that exact command. It's good to
centralize all knowledge of adb in android_commands.py and fix the issue there
(Otherwise someone might use RestartAdbServer which doesn't have CPU affinity)
There are existing calls to android_commands.py in this file (this is issue with
existing code not your changes)

On 2013/08/14 17:56:24, bulach wrote:

[bulach, 2013/08/14 18:09:59]

ahn, you're right! my confusion, I thought this would just "generate" the
commands rather than actually executing it.. new patch in a sec.

 
-  bb_annotations.PrintNamedStep('provision_devices')
   if options.reboot:
     RebootDevices()
   provision_cmd = ['build/android/provision_devices.py', '-t', options.target]
   if options.auto_reconnect:
     provision_cmd.append('--auto-reconnect')
   RunCmd(provision_cmd)
 
 
 def DeviceStatusCheck(_):
   bb_annotations.PrintNamedStep('device_status_check')
@@ skipping 122 matching lines @@
   if unknown_tests:
     return sys.exit('Unknown tests %s' % list(unknown_tests))
 
   setattr(options, 'target', options.factory_properties.get('target', 'Debug'))
 
   MainTestWrapper(options)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))