[Leveldb] Use std::{string,vector} instead of mojo::{String,Array}.

[Leveldb] Use std::{string,vector} instead of mojo::{String,Array}.

BUG=624136
Committed: https://crrev.com/5162d7bfcf870c1213cb5dbdf52fe779ae5cc797
Cr-Commit-Position: refs/heads/master@{#415879}

[leonhsl(Using Gerrit), 2016-08-26 06:51:58]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 06:52:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 06:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 06:55:48]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2016-08-26 07:04:53]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 07:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 08:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 08:20:33]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-08-26 08:53:41]

leon.han@intel.com changed reviewers:
+ erg@chromium.org, kinuko@chromium.org, yzshen@chromium.org

[leonhsl(Using Gerrit), 2016-08-26 08:53:42]

Hi, would you PTAL at this? Thanks.

Yuzhu:   For everything review
erg@:    For components/leveldb/ OWNER review
kinuko@: For content/browser/ OWNER review

[yzshen1, 2016-08-26 16:58:40]

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
File components/leveldb/leveldb_database_impl.cc (right):

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
components/leveldb/leveldb_database_impl.cc:98:
GetSliceFor(*(operations[i]->value)));
A malicious sender may send you a null value. And dereferencing it will cause
crash.

(The previous code is okay because mojo::Array is more tolerant, which will act
as empty array when it is null.)

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
File components/leveldb/leveldb_service_unittest.cc (right):

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
components/leveldb/leveldb_service_unittest.cc:45: void DoCapturesConstRef(T1*
out_t1,
I guess you could reuse the template above by changing line 25's type from
"Args*..." to "typename std::decay<Args>::type*..."

[leonhsl(Using Gerrit), 2016-08-29 03:23:37]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 03:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 04:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 04:52:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-08-29 05:05:13]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 05:05:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-08-29 06:36:17]

Thanks Yuzhu a lot for review. Uploaded ps#3 to address comments, PTAnL, Thanks.

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
File components/leveldb/leveldb_database_impl.cc (right):

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
components/leveldb/leveldb_database_impl.cc:98:
GetSliceFor(*(operations[i]->value)));
On 2016/08/26 16:58:40, yzshen1 wrote:
> A malicious sender may send you a null value. And dereferencing it will cause
> crash.
> 
> (The previous code is okay because mojo::Array is more tolerant, which will
act
> as empty array when it is null.)

Yeah, it is true. Done and thanks. Also confirmed no other similar problems as
such.

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
File components/leveldb/leveldb_service_unittest.cc (right):

https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
components/leveldb/leveldb_service_unittest.cc:45: void DoCapturesConstRef(T1*
out_t1,
On 2016/08/26 16:58:40, yzshen1 wrote:
> I guess you could reuse the template above by changing line 25's type from
> "Args*..." to "typename std::decay<Args>::type*..."

Done and thanks! I was not aware of existence of std::decay<> before!

[commit-bot: I haz the power, 2016-08-29 06:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 06:39:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-08-29 06:43:16]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 06:43:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 08:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 08:04:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yzshen1, 2016-08-29 15:48:16]

On 2016/08/29 06:36:17, leonhsl wrote:
> Thanks Yuzhu a lot for review. Uploaded ps#3 to address comments, PTAnL,
Thanks.
> 
>
https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
> File components/leveldb/leveldb_database_impl.cc (right):
> 
>
https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
> components/leveldb/leveldb_database_impl.cc:98:
> GetSliceFor(*(operations[i]->value)));
> On 2016/08/26 16:58:40, yzshen1 wrote:
> > A malicious sender may send you a null value. And dereferencing it will
cause
> > crash.
> > 
> > (The previous code is okay because mojo::Array is more tolerant, which will
> act
> > as empty array when it is null.)
> 
> Yeah, it is true. Done and thanks. Also confirmed no other similar problems as
> such.
> 
>
https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
> File components/leveldb/leveldb_service_unittest.cc (right):
> 
>
https://codereview.chromium.org/2285623002/diff/20001/components/leveldb/leve...
> components/leveldb/leveldb_service_unittest.cc:45: void DoCapturesConstRef(T1*
> out_t1,
> On 2016/08/26 16:58:40, yzshen1 wrote:
> > I guess you could reuse the template above by changing line 25's type from
> > "Args*..." to "typename std::decay<Args>::type*..."
> 
> Done and thanks! I was not aware of existence of std::decay<> before!

LGTM

[leonhsl(Using Gerrit), 2016-08-30 02:06:31]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 02:45:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:42:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 05:43:00]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2016-08-30 17:56:31]

lgtm

[leonhsl(Using Gerrit), 2016-08-31 02:55:45]

leon.han@intel.com changed reviewers:
+ piman@chromium.org
- kinuko@chromium.org

[leonhsl(Using Gerrit), 2016-08-31 02:55:45]

Hi, piman@, would you PTAL for OWNER review of content/ ? Thanks.

[piman, 2016-08-31 19:47:49]

lgtm

[leonhsl(Using Gerrit), 2016-09-01 03:07:47]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2016-09-01 03:08:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 04:23:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 04:35:10]

Description was changed from

==========
[Leveldb] Use std::{string,vector} instead of mojo::{String,Array}.

BUG=624136
==========

to

==========
[Leveldb] Use std::{string,vector} instead of mojo::{String,Array}.

BUG=624136

Committed: https://crrev.com/5162d7bfcf870c1213cb5dbdf52fe779ae5cc797
Cr-Commit-Position: refs/heads/master@{#415879}
==========

[commit-bot: I haz the power, 2016-09-01 04:35:12]

Patchset 3 (id:??) landed as
https://crrev.com/5162d7bfcf870c1213cb5dbdf52fe779ae5cc797
Cr-Commit-Position: refs/heads/master@{#415879}