content/browser/leveldb_wrapper_impl.h - Issue 2285623002: [Leveldb] Use std::{string,vector} instead of mojo::{String,Array}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/leveldb_wrapper_impl.h

Issue 2285623002: [Leveldb] Use std::{string,vector} instead of mojo::{String,Array}. (Closed)

Patch Set: Address comments from Yuzhu Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/leveldb_wrapper_impl.h

diff --git a/content/browser/leveldb_wrapper_impl.h b/content/browser/leveldb_wrapper_impl.h

index 97bca9ef81b4babaa79b7146d4ada7bd08cdc7e9..e4a978c303381978422ee172b03be126b2166f2c 100644

--- a/content/browser/leveldb_wrapper_impl.h

+++ b/content/browser/leveldb_wrapper_impl.h

@@ -107,7 +107,7 @@ class LevelDBWrapperImpl : public mojom::LevelDBWrapper {

void OnConnectionError();

void LoadMap(const base::Closure& completion_callback);

void OnLoadComplete(leveldb::mojom::DatabaseError status,

- mojo::Array<leveldb::mojom::KeyValuePtr> data);

+ std::vector<leveldb::mojom::KeyValuePtr> data);

void CreateCommitBatchIfNeeded();

void StartCommitTimer();

base::TimeDelta ComputeCommitDelay() const;