Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2285613002: Fix selectionDirection attribute value of INPUT/TEXTAREA just after creation (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix selectionDirection attribute value of INPUT/TEXTAREA just after creation. selectionDirection incorrectly returned "none" in such case even on non-Mac platforms. BUG=640861 Committed: https://crrev.com/1b3aa5da1f6257e84087e7fb7a1b7ed546177cae Cr-Commit-Position: refs/heads/master@{#414678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/forms/selection-direction.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/selection-direction-expected.txt View 6 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review this please? I think this is the last CL for crbug.com/640861.
4 years, 3 months ago (2016-08-26 07:27:50 UTC) #5
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-26 09:30:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285613002/1
4 years, 3 months ago (2016-08-26 09:30:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 09:33:46 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 09:35:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b3aa5da1f6257e84087e7fb7a1b7ed546177cae
Cr-Commit-Position: refs/heads/master@{#414678}

Powered by Google App Engine
This is Rietveld 408576698