Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 2285613002: Fix selectionDirection attribute value of INPUT/TEXTAREA just after creation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/selection-direction-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 55
56 namespace blink { 56 namespace blink {
57 57
58 using namespace HTMLNames; 58 using namespace HTMLNames;
59 59
60 HTMLTextFormControlElement::HTMLTextFormControlElement(const QualifiedName& tagN ame, Document& doc, HTMLFormElement* form) 60 HTMLTextFormControlElement::HTMLTextFormControlElement(const QualifiedName& tagN ame, Document& doc, HTMLFormElement* form)
61 : HTMLFormControlElementWithState(tagName, doc, form) 61 : HTMLFormControlElementWithState(tagName, doc, form)
62 , m_lastChangeWasUserEdit(false) 62 , m_lastChangeWasUserEdit(false)
63 , m_cachedSelectionStart(0) 63 , m_cachedSelectionStart(0)
64 , m_cachedSelectionEnd(0) 64 , m_cachedSelectionEnd(0)
65 , m_cachedSelectionDirection(SelectionHasNoDirection)
66 { 65 {
66 m_cachedSelectionDirection = doc.frame() && doc.frame()->editor().behavior() .shouldConsiderSelectionAsDirectional() ? SelectionHasForwardDirection : Selecti onHasNoDirection;
67 } 67 }
68 68
69 HTMLTextFormControlElement::~HTMLTextFormControlElement() 69 HTMLTextFormControlElement::~HTMLTextFormControlElement()
70 { 70 {
71 } 71 }
72 72
73 Node::InsertionNotificationRequest HTMLTextFormControlElement::insertedInto(Cont ainerNode* insertionPoint) 73 Node::InsertionNotificationRequest HTMLTextFormControlElement::insertedInto(Cont ainerNode* insertionPoint)
74 { 74 {
75 HTMLFormControlElementWithState::insertedInto(insertionPoint); 75 HTMLFormControlElementWithState::insertedInto(insertionPoint);
76 if (!insertionPoint->isConnected()) 76 if (!insertionPoint->isConnected())
(...skipping 942 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 } 1019 }
1020 1020
1021 void HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(const Ele ment& source) 1021 void HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(const Ele ment& source)
1022 { 1022 {
1023 const HTMLTextFormControlElement& sourceElement = static_cast<const HTMLText FormControlElement&>(source); 1023 const HTMLTextFormControlElement& sourceElement = static_cast<const HTMLText FormControlElement&>(source);
1024 m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit; 1024 m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit;
1025 HTMLFormControlElement::copyNonAttributePropertiesFromElement(source); 1025 HTMLFormControlElement::copyNonAttributePropertiesFromElement(source);
1026 } 1026 }
1027 1027
1028 } // namespace blink 1028 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/selection-direction-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698