[Extensions] Convert some SyncExtensionFunctions

[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140
Committed: https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146
Cr-Commit-Position: refs/heads/master@{#415170}

[Devlin, 2016-08-26 00:48:08]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 00:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 01:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:50:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-26 18:30:03]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 18:30:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:22:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-26 22:38:42]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:39:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-27 00:19:47]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-08-27 00:19:54]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-08-27 00:26:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 00:26:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:31:03]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-29 16:05:39]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-08-29 16:05:40]

lazyboy@, mind taking a look?

[lazyboy, 2016-08-29 18:01:50]

lgtm.

https://codereview.chromium.org/2285573002/diff/60001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/input_ime/background.js (right):

https://codereview.chromium.org/2285573002/diff/60001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/input_ime/background.js:82: // Disabled:
crbug.com/641425.
Add this change to CL description?

These don't work because InputMethodEngine isn't (and wasn't) available?

[Devlin, 2016-08-29 20:29:43]

Description was changed from

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

BUG=634140
==========

to

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140
==========

[Devlin, 2016-08-29 20:29:54]

https://codereview.chromium.org/2285573002/diff/60001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/input_ime/background.js (right):

https://codereview.chromium.org/2285573002/diff/60001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/input_ime/background.js:82: // Disabled:
crbug.com/641425.
On 2016/08/29 18:01:49, lazyboy wrote:
> Add this change to CL description?
> 
> These don't work because InputMethodEngine isn't (and wasn't) available?

Adjusted cl description.  These actually don't work because the input method
engine returns false for Set/UpdateMenuItems(), and appears to always have.

[Devlin, 2016-08-29 20:30:01]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-08-29 20:53:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:40:45]

Description was changed from

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140
==========

to

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140
==========

[commit-bot: I haz the power, 2016-08-30 05:40:46]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-30 05:43:11]

Description was changed from

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140
==========

to

==========
[Extensions] Convert some SyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140

Committed: https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146
Cr-Commit-Position: refs/heads/master@{#415170}
==========

[commit-bot: I haz the power, 2016-08-30 05:43:12]

Patchset 2 (id:??) landed as
https://crrev.com/94a2445fd9dacd5d11f906cec52b85b24b929146
Cr-Commit-Position: refs/heads/master@{#415170}