[Extensions] Convert some SyncExtensionFunctions

chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/input_ime/input_ime_api.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/macros.h"
@@ skipping 339 matching lines @@
 }
 
 InputMethodEngineBase* InputImeEventRouter::GetActiveEngine(
     const std::string& extension_id) {
   std::map<std::string, InputMethodEngine*>::iterator it =
       engine_map_.find(extension_id);
   return (it != engine_map_.end() && it->second->IsActive()) ? it->second
                                                              : nullptr;
 }
 
-bool InputImeClearCompositionFunction::RunSync() {
+ExtensionFunction::ResponseAction InputImeClearCompositionFunction::Run() {
   InputMethodEngine* engine = GetActiveEngine(
       Profile::FromBrowserContext(browser_context()), extension_id());
   if (!engine) {
-    SetResult(base::MakeUnique<base::FundamentalValue>(false));
-    return true;
+    return RespondNow(
+        OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
   }
 
   std::unique_ptr<ClearComposition::Params> parent_params(
       ClearComposition::Params::Create(*args_));
   const ClearComposition::Params::Parameters& params =
       parent_params->parameters;
 
-  SetResult(base::MakeUnique<base::FundamentalValue>(
-      engine->ClearComposition(params.context_id, &error_)));
-  return true;
+  return RespondNow(OneArgument(base::MakeUnique<base::FundamentalValue>(
+      engine->ClearComposition(params.context_id, &error_))));
 }
 
 bool InputImeHideInputViewFunction::RunAsync() {
   InputMethodEngine* engine = GetActiveEngine(
       Profile::FromBrowserContext(browser_context()), extension_id());
   if (!engine) {
     return true;
   }
   engine->HideInputView();
   return true;
 }
 
-bool InputImeSetCandidateWindowPropertiesFunction::RunSync() {
+ExtensionFunction::ResponseAction
+InputImeSetCandidateWindowPropertiesFunction::Run() {
   std::unique_ptr<SetCandidateWindowProperties::Params> parent_params(
       SetCandidateWindowProperties::Params::Create(*args_));
   const SetCandidateWindowProperties::Params::Parameters&
       params = parent_params->parameters;
 
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngine* engine =
       event_router ? event_router->GetEngine(extension_id(), params.engine_id)
                    : nullptr;
   if (!engine) {
-    SetResult(base::MakeUnique<base::FundamentalValue>(false));
-    return true;
+    return RespondNow(
+        OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
   }
 
   const SetCandidateWindowProperties::Params::Parameters::Properties&
       properties = params.properties;
 
   if (properties.visible &&
       !engine->SetCandidateWindowVisible(*properties.visible, &error_)) {
-    SetResult(base::MakeUnique<base::FundamentalValue>(false));
-    return true;
+    return RespondNow(
+        OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
   }
 
   InputMethodEngine::CandidateWindowProperty properties_out =
       engine->GetCandidateWindowProperty();
   bool modified = false;
 
   if (properties.cursor_visible) {
     properties_out.is_cursor_visible = *properties.cursor_visible;
     modified = true;
   }
@@ skipping 24 matching lines @@
   if (properties.auxiliary_text_visible) {
     properties_out.is_auxiliary_text_visible =
         *properties.auxiliary_text_visible;
     modified = true;
   }
 
   if (modified) {
     engine->SetCandidateWindowProperty(properties_out);
   }
 
-  SetResult(base::MakeUnique<base::FundamentalValue>(true));
-
-  return true;
+  return RespondNow(
+      OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
 }
 
-bool InputImeSetCandidatesFunction::RunSync() {
+ExtensionFunction::ResponseAction InputImeSetCandidatesFunction::Run() {
   InputMethodEngine* engine = GetActiveEngine(
       Profile::FromBrowserContext(browser_context()), extension_id());
   if (!engine) {
-    SetResult(base::MakeUnique<base::FundamentalValue>(true));
-    return true;
+    return RespondNow(
+        OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
   }
 
   std::unique_ptr<SetCandidates::Params> parent_params(
       SetCandidates::Params::Create(*args_));
   const SetCandidates::Params::Parameters& params =
       parent_params->parameters;
 
   std::vector<InputMethodEngine::Candidate> candidates_out;
   for (const auto& candidate_in : params.candidates) {
     candidates_out.push_back(InputMethodEngine::Candidate());
     candidates_out.back().value = candidate_in.candidate;
     candidates_out.back().id = candidate_in.id;
     if (candidate_in.label)
       candidates_out.back().label = *candidate_in.label;
     if (candidate_in.annotation)
       candidates_out.back().annotation = *candidate_in.annotation;
     if (candidate_in.usage) {
       candidates_out.back().usage.title = candidate_in.usage->title;
       candidates_out.back().usage.body = candidate_in.usage->body;
     }
   }
 
-  SetResult(base::MakeUnique<base::FundamentalValue>(
-      engine->SetCandidates(params.context_id, candidates_out, &error_)));
-  return true;
+  return RespondNow(OneArgument(base::MakeUnique<base::FundamentalValue>(
+      engine->SetCandidates(params.context_id, candidates_out, &error_))));
 }
 
-bool InputImeSetCursorPositionFunction::RunSync() {
+ExtensionFunction::ResponseAction InputImeSetCursorPositionFunction::Run() {
   InputMethodEngine* engine = GetActiveEngine(
       Profile::FromBrowserContext(browser_context()), extension_id());
   if (!engine) {
-    SetResult(base::MakeUnique<base::FundamentalValue>(false));
-    return true;
+    return RespondNow(
+        OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
   }
 
   std::unique_ptr<SetCursorPosition::Params> parent_params(
       SetCursorPosition::Params::Create(*args_));
   const SetCursorPosition::Params::Parameters& params =
       parent_params->parameters;
 
-  SetResult(base::MakeUnique<base::FundamentalValue>(engine->SetCursorPosition(
-      params.context_id, params.candidate_id, &error_)));
-  return true;
+  return RespondNow(OneArgument(
+      base::MakeUnique<base::FundamentalValue>(engine->SetCursorPosition(
+          params.context_id, params.candidate_id, &error_))));
 }
 
-bool InputImeSetMenuItemsFunction::RunSync() {
+ExtensionFunction::ResponseAction InputImeSetMenuItemsFunction::Run() {
   std::unique_ptr<SetMenuItems::Params> parent_params(
       SetMenuItems::Params::Create(*args_));
   const SetMenuItems::Params::Parameters& params =
       parent_params->parameters;
 
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngine* engine =
       event_router ? event_router->GetEngine(extension_id(), params.engine_id)
                    : nullptr;
-  if (!engine) {
-    error_ = kErrorEngineNotAvailable;
-    return false;
-  }
+  if (!engine)
+    return RespondNow(Error(kErrorEngineNotAvailable));
 
   std::vector<chromeos::input_method::InputMethodManager::MenuItem> items_out;
   for (const input_ime::MenuItem& item_in : params.items) {
     items_out.push_back(chromeos::input_method::InputMethodManager::MenuItem());
     SetMenuItemToMenu(item_in, &items_out.back());
   }
 
   if (!engine->SetMenuItems(items_out))
-    error_ = kErrorSetMenuItemsFail;
-  return true;
+    return RespondNow(Error(kErrorSetMenuItemsFail));
+  return RespondNow(NoArguments());
 }
 
-bool InputImeUpdateMenuItemsFunction::RunSync() {
+ExtensionFunction::ResponseAction InputImeUpdateMenuItemsFunction::Run() {
   std::unique_ptr<UpdateMenuItems::Params> parent_params(
       UpdateMenuItems::Params::Create(*args_));
   const UpdateMenuItems::Params::Parameters& params =
       parent_params->parameters;
 
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngine* engine =
       event_router ? event_router->GetEngine(extension_id(), params.engine_id)
                    : nullptr;
-  if (!engine) {
-    error_ = kErrorEngineNotAvailable;
-    return false;
-  }
+  if (!engine)
+    return RespondNow(Error(kErrorEngineNotAvailable));
 
   std::vector<chromeos::input_method::InputMethodManager::MenuItem> items_out;
   for (const input_ime::MenuItem& item_in : params.items) {
     items_out.push_back(chromeos::input_method::InputMethodManager::MenuItem());
     SetMenuItemToMenu(item_in, &items_out.back());
   }
 
   if (!engine->UpdateMenuItems(items_out))
-    error_ = kErrorUpdateMenuItemsFail;
-  return true;
+    return RespondNow(Error(kErrorUpdateMenuItemsFail));
+  return RespondNow(NoArguments());
 }
 
-bool InputImeDeleteSurroundingTextFunction::RunSync() {
+ExtensionFunction::ResponseAction InputImeDeleteSurroundingTextFunction::Run() {
   std::unique_ptr<DeleteSurroundingText::Params> parent_params(
       DeleteSurroundingText::Params::Create(*args_));
   const DeleteSurroundingText::Params::Parameters& params =
       parent_params->parameters;
 
   InputImeEventRouter* event_router =
       GetInputImeEventRouter(Profile::FromBrowserContext(browser_context()));
   InputMethodEngine* engine =
       event_router ? event_router->GetEngine(extension_id(), params.engine_id)
                    : nullptr;
-  if (!engine) {
-    error_ = kErrorEngineNotAvailable;
-    return false;
-  }
+  if (!engine)
+    return RespondNow(Error(kErrorEngineNotAvailable));
 
   engine->DeleteSurroundingText(params.context_id, params.offset, params.length,
                                 &error_);
-  return true;
+  return RespondNow(NoArguments());
 }
 
 ExtensionFunction::ResponseAction
 InputMethodPrivateNotifyImeMenuItemActivatedFunction::Run() {
   chromeos::input_method::InputMethodDescriptor current_input_method =
       chromeos::input_method::InputMethodManager::Get()
           ->GetActiveIMEState()
           ->GetCurrentInputMethod();
   std::string active_extension_id =
       chromeos::extension_ime_util::GetExtensionIDFromInputMethodID(
@@ skipping 41 matching lines @@
     return;
   InputMethodEngine* engine =
       GetActiveEngine(Profile::FromBrowserContext(details.browser_context),
                       details.extension_id);
   // Notifies the IME extension for IME ready with onActivate/onFocus events.
   if (engine)
     engine->Enable(engine->GetActiveComponentId());
 }
 
 }  // namespace extensions