Issue 22855011: Added date_added and folder_modification_time to BookmarkNodeData.

Issue 22855011: Added date_added and folder_modification_time to BookmarkNodeData. (Closed)

Created:
7 years, 4 months ago by Tom Cassiotis

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, dcheng

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Added date_added and folder_modification_time to BookmarkNodeData. BookmarkNodeData holds values for date_added and folder_modification_time so that it will be possible for bookmark_utils::CloneBookmarkNode can keep those values for cloned nodes. This change should not have any change in behavior. BUG=126092 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218891

Patch Set 1 #

Patch Set 2 : Fix clang and android compile errors. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -11 lines)			Patch
M	chrome/browser/bookmarks/bookmark_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_node_data_unittest.cc	View		7 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View		3 chunks	+22 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_drag_drop.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Tom Cassiotis

Scott please take a look. As discussed here: https://codereview.chromium.org/19287013/diff/51002/chrome/browser/undo/bookmark_undo_service.cc#newcode206

7 years, 4 months ago (2013-08-20 19:06:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/22855011/1

7 years, 4 months ago (2013-08-21 01:28:45 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 4 months ago (2013-08-21 05:19:56 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/22855011/27001

7 years, 4 months ago (2013-08-21 19:52:23 UTC) #5

Message was sent while issue was closed.

Change committed as 218891

Expand Messages | Collapse Messages