Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/bookmarks/bookmark_node_data_unittest.cc

Issue 22855011: Added date_added and folder_modification_time to BookmarkNodeData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix clang and android compile errors. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_node_data.cc ('k') | chrome/browser/bookmarks/bookmark_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_node_data_unittest.cc
diff --git a/chrome/browser/bookmarks/bookmark_node_data_unittest.cc b/chrome/browser/bookmarks/bookmark_node_data_unittest.cc
index 23d99f22d6c1927d0bc1c8717edc50c9149911b7..c600fd5d24d2ee0a8855f5abdf99ae5e8dc6fc45 100644
--- a/chrome/browser/bookmarks/bookmark_node_data_unittest.cc
+++ b/chrome/browser/bookmarks/bookmark_node_data_unittest.cc
@@ -64,6 +64,8 @@ TEST_F(BookmarkNodeDataTest, JustURL) {
EXPECT_TRUE(drag_data.elements[0].is_url);
EXPECT_EQ(url, drag_data.elements[0].url);
EXPECT_EQ(title, drag_data.elements[0].title);
+ EXPECT_TRUE(drag_data.elements[0].date_added.is_null());
+ EXPECT_TRUE(drag_data.elements[0].date_folder_modified.is_null());
EXPECT_EQ(0, drag_data.elements[0].children.size());
}
@@ -84,6 +86,9 @@ TEST_F(BookmarkNodeDataTest, URL) {
EXPECT_TRUE(drag_data.elements[0].is_url);
EXPECT_EQ(url, drag_data.elements[0].url);
EXPECT_EQ(title, drag_data.elements[0].title);
+ EXPECT_EQ(node->date_added(), drag_data.elements[0].date_added);
+ EXPECT_EQ(node->date_folder_modified(),
+ drag_data.elements[0].date_folder_modified);
ui::OSExchangeData data;
drag_data.Write(&profile, &data);
@@ -96,6 +101,8 @@ TEST_F(BookmarkNodeDataTest, URL) {
EXPECT_TRUE(read_data.elements[0].is_url);
EXPECT_EQ(url, read_data.elements[0].url);
EXPECT_EQ(title, read_data.elements[0].title);
+ EXPECT_TRUE(read_data.elements[0].date_added.is_null());
+ EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
EXPECT_TRUE(read_data.GetFirstNode(&profile) == node);
// Make sure asking for the node with a different profile returns NULL.
@@ -129,6 +136,9 @@ TEST_F(BookmarkNodeDataTest, Folder) {
ASSERT_EQ(1, drag_data.elements.size());
EXPECT_EQ(g12->GetTitle(), drag_data.elements[0].title);
EXPECT_FALSE(drag_data.elements[0].is_url);
+ EXPECT_EQ(g12->date_added(), drag_data.elements[0].date_added);
+ EXPECT_EQ(g12->date_folder_modified(),
+ drag_data.elements[0].date_folder_modified);
ui::OSExchangeData data;
drag_data.Write(&profile, &data);
@@ -141,6 +151,8 @@ TEST_F(BookmarkNodeDataTest, Folder) {
ASSERT_EQ(1, read_data.elements.size());
EXPECT_EQ(g12->GetTitle(), read_data.elements[0].title);
EXPECT_FALSE(read_data.elements[0].is_url);
+ EXPECT_TRUE(read_data.elements[0].date_added.is_null());
+ EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
// We should get back the same node when asking for the same profile.
const BookmarkNode* r_g12 = read_data.GetFirstNode(&profile);
@@ -185,6 +197,8 @@ TEST_F(BookmarkNodeDataTest, FolderWithChild) {
EXPECT_TRUE(read_child.is_url);
EXPECT_EQ(title, read_child.title);
EXPECT_EQ(url, read_child.url);
+ EXPECT_TRUE(read_data.elements[0].date_added.is_null());
+ EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
EXPECT_TRUE(read_child.is_url);
// And make sure we get the node back.
@@ -224,6 +238,8 @@ TEST_F(BookmarkNodeDataTest, MultipleNodes) {
EXPECT_TRUE(read_data.is_valid());
ASSERT_EQ(2, read_data.elements.size());
ASSERT_EQ(1, read_data.elements[0].children.size());
+ EXPECT_TRUE(read_data.elements[0].date_added.is_null());
+ EXPECT_TRUE(read_data.elements[0].date_folder_modified.is_null());
const BookmarkNodeData::Element& read_folder = read_data.elements[0];
EXPECT_FALSE(read_folder.is_url);
« no previous file with comments | « chrome/browser/bookmarks/bookmark_node_data.cc ('k') | chrome/browser/bookmarks/bookmark_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698