Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: content/renderer/input/render_widget_input_handler.cc

Issue 2285423002: Stop negating the overscroll velocity to enable the glow of main thread fling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/input/render_widget_input_handler.cc
diff --git a/content/renderer/input/render_widget_input_handler.cc b/content/renderer/input/render_widget_input_handler.cc
index 3ea242a1e554f38c8684921c04c07fb6751961eb..a67366787b0c4702064c1246526b4c395e274aec 100644
--- a/content/renderer/input/render_widget_input_handler.cc
+++ b/content/renderer/input/render_widget_input_handler.cc
@@ -517,7 +517,7 @@ void RenderWidgetInputHandler::DidOverscrollFromBlink(
// TODO(sataya.m): don't negate velocity once http://crbug.com/499743 is
dtapuska 2016/08/29 21:16:34 Do we need to remove this comment? Is this partial
majidvp 2016/08/31 19:39:40 Overscroll glow logic expects to receive delta and
bokan 2016/08/31 21:04:30 Yes, I believe that's correct.
// fixed.
params->current_fling_velocity =
- gfx::Vector2dF(-velocity.width, -velocity.height);
+ gfx::Vector2dF(velocity.width, velocity.height);
params->causal_event_viewport_point = gfx::PointF(position.x, position.y);
// If we're currently handling an event, stash the overscroll data such that
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698