Pass the physical scroll delta through the scroll customization path.

Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=591124
Committed: https://crrev.com/1535512d6b044044e58111011a48ffd07194b49c
Cr-Commit-Position: refs/heads/master@{#378834}

[bokan, 2016-03-01 18:51:29]

Patchset #1 (id:1) has been deleted

[bokan, 2016-03-01 18:51:46]

Description was changed from

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=
==========

to

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=
==========

[bokan, 2016-03-01 18:51:47]

bokan@chromium.org changed reviewers:
+ tdresser@chromium.org

[bokan, 2016-03-01 18:53:13]

This patch fixes some of the TODOs about negative/inverted deltas in
ScrollCustomization, I think this makes sense since you'd want to be able to add
your scroll delta to element.scrollTop/Left directly.

[tdresser, 2016-03-01 19:24:09]

Thanks!

LGTM with nits.

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/TopControls.cpp (right):

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/TopControls.cpp:68: // top controls to hide
(negative offset difference).
Would it be clearer to just take oldOffset - newContentOffset?

different -> difference

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/EventHandler.cpp:2385: // (negative scroll
delta).
Both units are in screen space, right?

I'd say something like:

// Negate, since the gesture event stores finger movement, and scrolling occurs
in the direction opposite the direction the finger moves.

[bokan, 2016-03-01 19:26:54]

Description was changed from

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=
==========

to

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=591124
==========

[bokan, 2016-03-01 19:40:57]

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/TopControls.cpp (right):

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/TopControls.cpp:68: // top controls to hide
(negative offset difference).
On 2016/03/01 19:24:09, tdresser wrote:
> Would it be clearer to just take oldOffset - newContentOffset?
> 
> different -> difference

Done. Ugh, I'm a typo machine...

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1755773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/EventHandler.cpp:2385: // (negative scroll
delta).
On 2016/03/01 19:24:09, tdresser wrote:
> Both units are in screen space, right?
> 
> I'd say something like:
> 
> // Negate, since the gesture event stores finger movement, and scrolling
occurs
> in the direction opposite the direction the finger moves.

Done.

[bokan, 2016-03-01 19:41:46]

bokan@chromium.org changed reviewers:
+ jbroman@chromium.org

[bokan, 2016-03-01 19:41:47]

+jbroman@ stampify all the CLs!

[jbroman, 2016-03-01 19:53:37]

lgtm

[bokan, 2016-03-02 07:23:11]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-03-02 07:23:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1755773002/#ps40001
(title: "Addressed review feedback")

[commit-bot: I haz the power, 2016-03-02 07:23:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755773002/40001

[commit-bot: I haz the power, 2016-03-02 08:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 08:48:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tdresser, 2016-03-02 18:18:43]

Still LGTM.

Thanks for cleaning up those deltas.

[bokan, 2016-03-02 18:19:18]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-03-02 18:19:18]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1755773002/#ps60001
(title: "Updated LayoutTest")

[commit-bot: I haz the power, 2016-03-02 18:19:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755773002/60001

[commit-bot: I haz the power, 2016-03-02 21:18:32]

Description was changed from

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=591124
==========

to

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=591124
==========

[commit-bot: I haz the power, 2016-03-02 21:18:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-02 21:20:00]

Description was changed from

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=591124
==========

to

==========
Pass the physical scroll delta through the scroll customization path.

The scroll customization path of scrolling passes through the gesture event
deltas which are inverted from actual scroll deltas. E.g. A finger moving
up and left has positive gesture event delta but causes the page to scroll down
and right which increases the page's scrollX and scrollY.

This patch converts the event delta to a scroll delta before feeding it into the
scroll customization path. I've also "uninverted" some of the helper methods
that were relying on this like LocalFrame::applyScrollDelta and
TopControls::scrollBy.

BUG=591124

Committed: https://crrev.com/1535512d6b044044e58111011a48ffd07194b49c
Cr-Commit-Position: refs/heads/master@{#378834}
==========

[commit-bot: I haz the power, 2016-03-02 21:20:01]

Patchset 3 (id:??) landed as
https://crrev.com/1535512d6b044044e58111011a48ffd07194b49c
Cr-Commit-Position: refs/heads/master@{#378834}