[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG=640907
BUG=615893

[Jane, 2016-08-26 17:38:16]

Description was changed from

==========
[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's always right-aligned.

See comparative screenshots:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGMlcwcGpieHE2eTg/vie...

BUG=640907
BUG=615893
==========

to

==========
[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGMlcwcGpieHE2eTg/vie...

BUG=640907
BUG=615893
==========

[Jane, 2016-08-26 17:39:14]

Description was changed from

==========
[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGMlcwcGpieHE2eTg/vie...

BUG=640907
BUG=615893
==========

to

==========
[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG=640907
BUG=615893
==========

[Jane, 2016-08-26 17:45:15]

janeliulwq@google.com changed reviewers:
+ sky@chromium.org

[Jane, 2016-08-26 17:45:16]

Hi sky@, this CL fixes the RTL bug in a hopefully better way.
I discussed with bettes@ and we decided that we should first make the change of
pushing the profile badge to the LHS on RTL layouts. That would make more sense.

Then from there, since the profile badge is now left-aligned, the profile icon
should be right-aligned on RTL layouts; this includes both the profile icon
image itself (already right-aligned), as well as the circular mask for the
profile icon image (which is always left-aligned regardless of the layout). Thus
I added another line to bump the circular mask to the right for RTL layouts. The
bump is needed because on the new user menu, the profile badge extends out of
the profile icon by badge_spacing().
Hopefully this explains the change better. Thanks!

[sky, 2016-08-26 19:18:27]

https://codereview.chromium.org/2286813002/diff/1/chrome/browser/ui/views/pro...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2286813002/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:381:
(base::i18n::IsRTL() ? badge_spacing() : 0),
In general we use the various GetMirrored* functions in View to adjust for rtl.
That you're doing something special here typically indicates something may be
wrong. AFAICT circular_mask_ is intended to be around the image drawn by
LabelButton. If that's right, why do you need circular_mask_? Can't you
calculate it when needed directly from the bounds of image()? I'm specifically
suggesting something like this:

void PaintChildren() {
  ...
  gfx::Rect clip_bounds = image()->GetMirroredBounds();
  gfx::Path clip_mask;
  clip_mask.AddCircle(use clip_bounds to calculate circle, shouldn't need to
adjust for rtl as GetMirroredBounds() does that for you);
  ...
?
}

In looking at this code a bit more, I'm also unclear as to why the path is
clipped in both OnPaint and PaintChildren? Don't you only care about
PaintChildren?

https://codereview.chromium.org/2286813002/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:435: // For RTL
layouts, left-align the profile badge.
Similar comment here. Generally you calculate the value in ltr, and then
somewhere along the line use one of the GetMirrored* functions.