Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2285323002: [Mac] Fix for fullscreen toolbar (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for fullscreen toolbar Added back mouse tracking to fix an edge case where the menu bar disappears when but the mouse is still hovering the toolbar. The tracking area is only used to keep the toolbar active when this happens. The toolbar will hide when the mouse leaves the tracking area. BUG=639562 Review-Url: https://codereview.chromium.org/2272783002 Cr-Commit-Position: refs/heads/master@{#414888} (cherry picked from commit e776f9c0602bafaf7ec33d022f543e86c4191a8f) Committed: https://chromium.googlesource.com/chromium/src/+/f47d14d961ef70dea76db3e01527783158a2f36a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -121 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h View 6 chunks +44 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm View 23 chunks +185 lines, -74 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years, 3 months ago (2016-08-29 17:11:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f47d14d961ef70dea76db3e01527783158a2f36a.

Powered by Google App Engine
This is Rietveld 408576698