Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2285163003: [Offline pages] Fixing a crash when notification for removed downloaded page is clicked (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
Reviewers:
Dmitry Titov, dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing a crash when notification for removed downloaded page is clicked BUG=641858 R=dimich@chromium.org Committed: https://crrev.com/76e9521d7b7b24b54691cc0b08d8589ab7b0561e Cr-Commit-Position: refs/heads/master@{#415122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fgorski
PTAL
4 years, 3 months ago (2016-08-29 16:09:24 UTC) #2
dewittj
drive by morning review :) lgtm
4 years, 3 months ago (2016-08-29 16:14:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285163003/1
4 years, 3 months ago (2016-08-29 17:17:41 UTC) #8
Dmitry Titov
lgtm
4 years, 3 months ago (2016-08-29 17:25:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:55:32 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:58:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76e9521d7b7b24b54691cc0b08d8589ab7b0561e
Cr-Commit-Position: refs/heads/master@{#415122}

Powered by Google App Engine
This is Rietveld 408576698