Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2285163003: [Offline pages] Fixing a crash when notification for removed downloaded page is clicked (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_b ridge.h" 5 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_b ridge.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 download_ui_adapter_->GetAllItems(); 171 download_ui_adapter_->GetAllItems();
172 ToJavaOfflinePageDownloadItemList(env, j_result_obj, items); 172 ToJavaOfflinePageDownloadItemList(env, j_result_obj, items);
173 } 173 }
174 174
175 ScopedJavaLocalRef<jobject> OfflinePageDownloadBridge::GetItemByGuid( 175 ScopedJavaLocalRef<jobject> OfflinePageDownloadBridge::GetItemByGuid(
176 JNIEnv* env, 176 JNIEnv* env,
177 const JavaParamRef<jobject>& obj, 177 const JavaParamRef<jobject>& obj,
178 const JavaParamRef<jstring>& j_guid) { 178 const JavaParamRef<jstring>& j_guid) {
179 std::string guid = ConvertJavaStringToUTF8(env, j_guid); 179 std::string guid = ConvertJavaStringToUTF8(env, j_guid);
180 const DownloadUIItem* item = download_ui_adapter_->GetItem(guid); 180 const DownloadUIItem* item = download_ui_adapter_->GetItem(guid);
181 if (item == nullptr)
182 return ScopedJavaLocalRef<jobject>();
181 return ToJavaOfflinePageDownloadItem(env, *item); 183 return ToJavaOfflinePageDownloadItem(env, *item);
182 } 184 }
183 185
184 void OfflinePageDownloadBridge::DeleteItemByGuid( 186 void OfflinePageDownloadBridge::DeleteItemByGuid(
185 JNIEnv* env, 187 JNIEnv* env,
186 const JavaParamRef<jobject>& obj, 188 const JavaParamRef<jobject>& obj,
187 const JavaParamRef<jstring>& j_guid) { 189 const JavaParamRef<jstring>& j_guid) {
188 std::string guid = ConvertJavaStringToUTF8(env, j_guid); 190 std::string guid = ConvertJavaStringToUTF8(env, j_guid);
189 download_ui_adapter_->DeleteItem(guid); 191 download_ui_adapter_->DeleteItem(guid);
190 } 192 }
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 352
351 DownloadUIAdapter* adapter = 353 DownloadUIAdapter* adapter =
352 DownloadUIAdapter::FromOfflinePageModel(offline_page_model); 354 DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
353 355
354 return reinterpret_cast<jlong>( 356 return reinterpret_cast<jlong>(
355 new OfflinePageDownloadBridge(env, obj, adapter, browser_context)); 357 new OfflinePageDownloadBridge(env, obj, adapter, browser_context));
356 } 358 }
357 359
358 } // namespace android 360 } // namespace android
359 } // namespace offline_pages 361 } // namespace offline_pages
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698