Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Remove accidentally added new file during rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
index bcb487ef2e992acdb7c3d9e5199e4ec2cc4c5204..7863a92dcd44b5a9ba5f6571031065275fc1ed41 100644
--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
@@ -214,11 +214,9 @@ void RecentTabSuggestionsProvider::NotifyStatusChanged(
ContentSuggestion RecentTabSuggestionsProvider::ConvertOfflinePage(
const OfflinePageItem& offline_page) const {
- // TODO(vitaliii): Make sure the URL is actually opened as an offline URL
- // and not just as a downloaded file.
Marc Treib 2016/10/05 09:15:23 I guess this TODO kinda still applies, maybe like
jianli 2016/10/05 20:34:16 Done.
ContentSuggestion suggestion(provided_category_,
base::IntToString(offline_page.offline_id),
- offline_page.GetOfflineURL());
+ offline_page.url);
if (offline_page.title.empty()) {
// TODO(vitaliii): Remove this fallback once the OfflinePageModel provides

Powered by Google App Engine
This is Rietveld 408576698