Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

Issue 2284933002: Remove OfflineURL from offline page (Closed)
Patch Set: Remove accidentally added new file during rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
index d6515af0d8a8b740506bc7af48682913079ba7c3..2688b518a116145681defc770dbfc367d41e0155 100644
--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
@@ -145,11 +145,11 @@ TEST_F(RecentTabSuggestionsProviderTest, ShouldConvertToSuggestions) {
OnNewSuggestions(_, recent_tabs_category(),
UnorderedElementsAre(
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test1.mhtml")),
+ GURL("http://dummy.com/1")),
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test2.mhtml")),
+ GURL("http://dummy.com/2")),
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test3.mhtml")))));
+ GURL("http://dummy.com/3")))));
FireOfflinePageModelChanged(offline_pages);
}
@@ -166,11 +166,11 @@ TEST_F(RecentTabSuggestionsProviderTest, ShouldSortByMostRecentlyVisited) {
OnNewSuggestions(
_, recent_tabs_category(),
ElementsAre(Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test3.mhtml")),
+ GURL("http://dummy.com/3")),
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test1.mhtml")),
+ GURL("http://dummy.com/1")),
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test2.mhtml")))));
+ GURL("http://dummy.com/2")))));
FireOfflinePageModelChanged(offline_pages);
}
@@ -197,9 +197,9 @@ TEST_F(RecentTabSuggestionsProviderTest, ShouldDismiss) {
OnNewSuggestions(_, recent_tabs_category(),
UnorderedElementsAre(
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test1.mhtml")),
+ GURL("http://dummy.com/1")),
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test4.mhtml")))));
+ GURL("http://dummy.com/4")))));
FireOfflinePageModelChanged(model()->items());
Mock::VerifyAndClearExpectations(observer());
@@ -212,9 +212,9 @@ TEST_F(RecentTabSuggestionsProviderTest, ShouldDismiss) {
EXPECT_THAT(
dismissed_suggestions,
UnorderedElementsAre(Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test2.mhtml")),
+ GURL("http://dummy.com/2")),
Property(&ContentSuggestion::url,
- GURL("file:///some/folder/test3.mhtml"))));
+ GURL("http://dummy.com/3"))));
// Clear dismissed suggestions.
provider()->ClearDismissedSuggestionsForDebugging(recent_tabs_category());

Powered by Google App Engine
This is Rietveld 408576698