Move WebSocketHandleImpl into Blink (take 2)

Move WebSocketHandleImpl into Blink

This is a revision to https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be reverted due to a linker error impacting Android bots w/ symbol_level=1. The delta from that CL is to extract WebSocketHandle as a pure interface so that the unit test can simply mock it out without need to link against implementations of WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/1c2bd80368022c0481cae0d3f7ed8cd7511666d4
Cr-Commit-Position: refs/heads/master@{#415798}

[darin (slow to review), 2016-08-25 21:59:10]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:59:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:42:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[darin (slow to review), 2016-08-26 04:54:41]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 04:54:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darin (slow to review), 2016-08-26 04:55:23]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-08-26 04:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 04:58:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[darin (slow to review), 2016-08-26 05:01:47]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 05:02:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 06:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 06:07:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[darin (slow to review), 2016-08-26 22:25:08]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:25:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:58:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[darin (slow to review), 2016-08-27 21:23:45]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 21:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darin (slow to review), 2016-08-27 21:31:45]

darin@chromium.org changed reviewers:
+ yhirano@chromium.org

[commit-bot: I haz the power, 2016-08-27 22:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 22:59:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[darin (slow to review), 2016-08-28 02:13:52]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-28 02:14:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-28 02:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-28 02:58:41]

Dry run: This issue passed the CQ dry run.

[darin (slow to review), 2016-08-29 17:05:54]

Description was changed from

==========
Move WebSocketHandleImpl into Blink
==========

to

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

TBR=tsepez@chromium.org
==========

[darin (slow to review), 2016-08-29 17:05:54]

darin@chromium.org changed reviewers:
+ tsepez@chromium.org

[darin (slow to review), 2016-08-29 17:07:03]

Description was changed from

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

TBR=tsepez@chromium.org
==========

to

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org
==========

[darin (slow to review), 2016-08-29 17:07:45]

This CL has a trivial mojom change. Just moving the directory location for the
mojom file. Hence, TBR= for IPC security review.

[darin (slow to review), 2016-08-29 17:08:11]

Patchset #2 (id:40001) has been deleted

[darin (slow to review), 2016-08-29 17:08:20]

Patchset #2 (id:60001) has been deleted

[Tom Sepez, 2016-08-29 17:08:31]

RS LGTM on moving existing .mojom file + module rename.

[darin (slow to review), 2016-08-29 17:08:39]

Patchset #2 (id:80001) has been deleted

[darin (slow to review), 2016-08-29 17:13:21]

Patchset #1 (id:1) has been deleted

[darin (slow to review), 2016-08-29 17:13:31]

Patchset #1 (id:100001) has been deleted

[yhirano, 2016-08-30 06:01:20]

https://codereview.chromium.org/2284473002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2284473002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp:181:
m_handle->initialize(Platform::current()->interfaceProvider());
I found I don't understand this logic. My understanding is the above
document()->frame()->interfaceProvider() is connected to a interface registry
living in the associated RenderFrameHostImpl. How about
Platform::current()->interfaceProvider()? Is this interface provider connected
to a interface registry that supports websocket?

[yhirano, 2016-08-30 07:43:10]

lgtm

https://codereview.chromium.org/2284473002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2284473002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp:181:
m_handle->initialize(Platform::current()->interfaceProvider());
On 2016/08/30 06:01:20, yhirano wrote:
> I found I don't understand this logic. My understanding is the above
> document()->frame()->interfaceProvider() is connected to a interface registry
> living in the associated RenderFrameHostImpl. How about
> Platform::current()->interfaceProvider()? Is this interface provider connected
> to a interface registry that supports websocket?

Sorry, I overlooked the AddUIThreadInterface call in
render_process_host_impl.cc.

https://codereview.chromium.org/2284473002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp
(right):

https://codereview.chromium.org/2284473002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp:127: if
(!Platform::current()) {
This branch can be deleted (see https://codereview.chromium.org/2276433003/).

[darin (slow to review), 2016-08-30 14:14:32]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 14:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:11:34]

Dry run: This issue passed the CQ dry run.

[darin (slow to review), 2016-08-30 19:08:00]

The CQ bit was checked by darin@chromium.org

[darin (slow to review), 2016-08-30 19:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2284473002/#ps160001
(title: "Removed unnecessary branch in onConnectionError")

[commit-bot: I haz the power, 2016-08-30 19:08:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:14:47]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[darin (slow to review), 2016-08-30 22:43:21]

The CQ bit was checked by darin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 22:44:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 01:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:03:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[darin (slow to review), 2016-08-31 04:24:37]

The CQ bit was checked by darin@chromium.org

[darin (slow to review), 2016-08-31 04:24:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2284473002/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-31 04:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 04:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 04:29:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[darin (slow to review), 2016-08-31 19:23:38]

The CQ bit was checked by darin@chromium.org

[darin (slow to review), 2016-08-31 19:23:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2284473002/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-31 19:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 23:19:14]

Description was changed from

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org
==========

[commit-bot: I haz the power, 2016-08-31 23:19:17]

Committed patchset #5 (id:200001)

[commit-bot: I haz the power, 2016-08-31 23:22:05]

Description was changed from

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
Move WebSocketHandleImpl into Blink

This is a revision to
https://crrev.com/b8df2228b7039e0326e6098e74547539fe9ef4e0, which had to be
reverted due to a linker error impacting Android bots w/ symbol_level=1. The
delta from that CL is to extract WebSocketHandle as a pure interface so that the
unit test can simply mock it out without need to link against implementations of
WebSocketHandle methods.

R=yhirano@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/1c2bd80368022c0481cae0d3f7ed8cd7511666d4
Cr-Commit-Position: refs/heads/master@{#415798}
==========

[commit-bot: I haz the power, 2016-08-31 23:22:08]

Patchset 5 (id:??) landed as
https://crrev.com/1c2bd80368022c0481cae0d3f7ed8cd7511666d4
Cr-Commit-Position: refs/heads/master@{#415798}