Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2284123002: [DevTools] Format console.log(new Error()) same as console.log(new Error().stack) (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Format console.log(new Error()) same as console.log(new Error().stack) Then DevTools will linkify links from error.stack. BUG=610559 R=lushnikov@chromium.org Committed: https://crrev.com/cdcbb06b51d195d106b4a217a6fa411fd8b54a66 Cr-Commit-Position: refs/heads/master@{#415145}

Patch Set 1 #

Patch Set 2 : removed elipsis #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -121 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-exception-source-url-expected.txt View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-promise-reject-and-handle-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt View 1 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 1 chunk +1 line, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/console/console-uncaught-promise-no-inspector-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-throw-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-undefined-override-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 1 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-eval-syntax-error-expected.txt View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt View 1 2 chunks +36 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-message-from-inline-with-url-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt View 1 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-stack-overflow-expected.txt View 1 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-expected.txt View 1 1 chunk +10 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt View 1 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-in-worker-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error-expected.txt View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-xpath-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/exception-objects-expected.txt View 1 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/function-name-in-console-message-stack-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe-expected.txt View 1 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html View 1 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt View 1 1 chunk +13 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt View 1 1 chunk +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 2 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kozy
Andrey, please take a look!
4 years, 3 months ago (2016-08-27 01:04:01 UTC) #1
kozy
Andrey, it's ready for review, please take another look!
4 years, 3 months ago (2016-08-27 02:02:56 UTC) #2
lushnikov
can you please attach a screenshot of visual changes? (there are some, right?)
4 years, 3 months ago (2016-08-29 22:00:37 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/2284123002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt (right): https://codereview.chromium.org/2284123002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt#newcode27 third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt:27: Error: errr is there no stack at all? ...
4 years, 3 months ago (2016-08-29 22:05:21 UTC) #4
kozy
https://codereview.chromium.org/2284123002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt File third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt (right): https://codereview.chromium.org/2284123002/diff/20001/third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt#newcode27 third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt:27: Error: errr On 2016/08/29 22:05:21, lushnikov wrote: > is ...
4 years, 3 months ago (2016-08-30 01:19:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284123002/20001
4 years, 3 months ago (2016-08-30 03:49:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 05:17:58 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:20:12 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cdcbb06b51d195d106b4a217a6fa411fd8b54a66
Cr-Commit-Position: refs/heads/master@{#415145}

Powered by Google App Engine
This is Rietveld 408576698