Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 22840006: Revert 217770 "Landing https://codereview.chromium.org/18769010/." (Closed)

Created:
7 years, 4 months ago by Evan Stade
Modified:
7 years, 4 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 217770 "Landing https://codereview.chromium.org/18769010/." > Landing https://codereview.chromium.org/18769010/. > > This turned out to be a tricky patch to land, so I'm landing https://codereview.chromium.org/18769010/ on behalf of elham@google.com. The original patch has all the requisite LGTMs so I'm just force-committing it here. > > BUG=WebRTC bug 1198 > TEST=Tested with Chrome and FireFox browser > > Review URL: https://codereview.chromium.org/23172002 TBR=phoglund@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -180 lines) Patch
M trunk/src/chrome/browser/media/webrtc_browsertest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/test/data/webrtc/adapter.js View 1 chunk +0 lines, -154 lines 0 comments Download
M trunk/src/chrome/test/data/webrtc/getusermedia.js View 3 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/test/data/webrtc/jsep01_call.js View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/data/webrtc/manual/constraints.html View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/test/data/webrtc/manual/constraints.js View 2 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/test/data/webrtc/manual/peerconnection.html View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/data/webrtc/manual/peerconnection.js View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/data/webrtc/webrtc_jsep01_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/test/data/webrtc/webrtc_video_quality_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/test/functional/media_stream_infobar.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/functional/webrtc_brutality_test.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/functional/webrtc_test_base.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
7 years, 4 months ago (2013-08-15 17:29:04 UTC) #1
Evan Stade
7 years, 4 months ago (2013-08-15 17:34:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r217808.

Powered by Google App Engine
This is Rietveld 408576698