Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23172002: Landing https://codereview.chromium.org/18769010/. (Closed)

Created:
7 years, 4 months ago by phoglund_chromium
Modified:
7 years, 4 months ago
Reviewers:
CC:
chromium-reviews, dennis_jeffrey, feature-media-reviews_chromium.org, anantha, dyu1
Visibility:
Public.

Description

Landing https://codereview.chromium.org/18769010/. This turned out to be a tricky patch to land, so I'm landing https://codereview.chromium.org/18769010/ on behalf of elham@google.com. The original patch has all the requisite LGTMs so I'm just force-committing it here. Landed on behalf of elham@google.com. BUG=WebRTC bug 1198 TEST=Tested with Chrome and FireFox browser Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -21 lines) Patch
M chrome/browser/media/webrtc_browsertest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/webrtc/adapter.js View 1 chunk +154 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/getusermedia.js View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/test/data/webrtc/jsep01_call.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webrtc/manual/constraints.html View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/data/webrtc/manual/constraints.js View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webrtc/webrtc_jsep01_test.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webrtc/webrtc_video_quality_test.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/functional/media_stream_infobar.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/webrtc_brutality_test.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/webrtc_test_base.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
phoglund_chromium
Committed patchset #1 manually as r217770.
7 years, 4 months ago (2013-08-15 08:09:25 UTC) #1
Evan Stade
7 years, 4 months ago (2013-08-15 17:23:33 UTC) #2
Message was sent while issue was closed. 
On 2013/08/15 08:09:25, phoglund wrote:
> Committed patchset #1 manually as r217770.

this seems to have broken telemetry_unittests on Mac10.6 Tests (3). Here is
where it started failing:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/b...

Here is part of the relevant bot output:

[ RUN      ] PlayActionTest.testPlayWaitForPlayTimeout
Traceback (most recent call last):
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/page/actions/play_unittest.py",
line 69, in testPlayWaitForPlayTimeout
    self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/web_contents.py",
line 55, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(expr, timeout)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_backend.py",
line 190, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, timeout)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_runtime.py",
line 46, in Evaluate
    res = self._inspector_backend.SyncRequest(request, timeout)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_backend.py",
line 294, in SyncRequest
    self._HandleNotification(res)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_backend.py",
line 234, in _HandleNotification
    raise exceptions.TabCrashException()
TabCrashException

[  FAILED  ] PlayActionTest.testPlayWaitForPlayTimeout (1157 ms)
[ RUN      ] PlayActionTest.testPlayWithAllSelector
[       OK ] PlayActionTest.testPlayWithAllSelector (1264 ms)
[ RUN      ] PlayActionTest.testPlayWithNoSelector
[       OK ] PlayActionTest.testPlayWithNoSelector (1213 ms)
[ RUN      ] PlayActionTest.testPlayWithVideoSelector
[       OK ] PlayActionTest.testPlayWithVideoSelector (1220 ms)
[ RUN      ] PlayActionTest.testPlayWithoutWaitForEnded
[       OK ] PlayActionTest.testPlayWithoutWaitForEnded (1191 ms)
[----------] 7 tests (12781 ms total)

[----------] 2 tests
[ RUN      ] ScrollActionTest.testBoundingClientRect
[       OK ] ScrollActionTest.testBoundingClientRect (1052 ms)
[ RUN      ] ScrollActionTest.testScrollAction
[       OK ] ScrollActionTest.testScrollAction (1162 ms)
[----------] 2 tests (2214 ms total)

[----------] 5 tests
[ RUN      ] SeekActionTest.testSeekWaitForSeekTimeout
Traceback (most recent call last):
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/page/actions/seek_unittest.py",
line 66, in testSeekWaitForSeekTimeout
    self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_SEEKED_CHECK))
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/web_contents.py",
line 55, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(expr, timeout)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_backend.py",
line 190, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, timeout)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_runtime.py",
line 46, in Evaluate
    res = self._inspector_backend.SyncRequest(request, timeout)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_backend.py",
line 294, in SyncRequest
    self._HandleNotification(res)
  File
"/Volumes/data/b/build/slave/Mac10_6_Tests__3_/build/src/tools/telemetry/telemetry/core/chrome/inspector_backend.py",
line 234, in _HandleNotification
    raise exceptions.TabCrashException()
TabCrashException

[  FAILED  ] SeekActionTest.testSeekWaitForSeekTimeout (1157 ms)

Powered by Google App Engine
This is Rietveld 408576698