Create bookmarks component with names of bookmark preferences

chrome/common/pref_names.h

Index: chrome/common/pref_names.h
diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
index 717032ac624cb07fce06d401e225d14739b12877..18ffd65e48b4c57942ef212d15af5fa6bd0dba79 100644
--- a/chrome/common/pref_names.h
+++ b/chrome/common/pref_names.h
@@ -12,6 +12,7 @@
 #include "build/build_config.h"
 
 #include "components/autofill/core/common/autofill_pref_names.h"
+#include "components/bookmarks/core/common/bookmark_pref_names.h"

[tfarina, 2014/04/09 15:28:26]

not lgtm, because of this change.

+Lei, for chrome/OWNERS.

[Lei Zhang, 2014/04/09 17:58:45]

Well, this is consistent with the #includes surrounding it, so I wouldn't nack
this CL for doing what's already done.

Looking at chrome_switches.h, it has included base and content switches for a
long time. There might be other files in chrome/common that does this as well.

For base, and components, since they are meant to be reused, it's good to only
#include what's necessary. The chrome directory, OTOH, is intended to be an edge
node on the other end of the dependency graph, so a little extra work for the
C++ preprocessor here is ok, since it's saving developer time and not a
frivolous #include that adds no value.

 #include "components/signin/core/common/signin_pref_names.h"
 
 namespace prefs {
@@ -50,9 +51,6 @@ extern const char kOwnerLocale[];
 extern const char kDefaultCharset[];
 extern const char kAcceptLanguages[];
 extern const char kStaticEncodings[];
-extern const char kShowBookmarkBar[];
-extern const char kShowAppsShortcutInBookmarkBar[];
-extern const char kBookmarkEditorExpandedNodes[];
 extern const char kWebKitCommonScript[];
 extern const char kWebKitStandardFontFamily[];
 extern const char kWebKitFixedFontFamily[];
@@ -354,7 +352,6 @@ extern const char kAutofillDialogSaveData[];
 extern const char kAutofillDialogWalletShippingSameAsBilling[];
 extern const char kAutofillGeneratedCardBubbleTimesShown[];
 extern const char kAutofillDialogDefaults[];
-extern const char kEditBookmarksEnabled[];
 
 extern const char kPinnedTabs[];
 
@@ -447,9 +444,6 @@ extern const char kCrashReportingEnabled[];
 extern const char kMetricsInitialLogs[];
 extern const char kMetricsOngoingLogs[];
 
-extern const char kBookmarkPromptEnabled[];
-extern const char kBookmarkPromptImpressionCount[];
-
 extern const char kVariationsLastFetchTime[];
 extern const char kVariationsRestrictParameter[];
 extern const char kVariationsSeed[];