Create bookmarks component with names of bookmark preferences

chrome/common/pref_names.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Constants for the names of various preferences, for easier changing.
 
 #ifndef CHROME_COMMON_PREF_NAMES_H_
 #define CHROME_COMMON_PREF_NAMES_H_
 
 #include <stddef.h>
 
 #include "build/build_config.h"
 
 #include "components/autofill/core/common/autofill_pref_names.h"
+#include "components/bookmarks/core/common/bookmark_pref_names.h"

[tfarina, 2014/04/09 15:28:26]

not lgtm, because of this change.

+Lei, for chrome/OWNERS.

[Lei Zhang, 2014/04/09 17:58:45]

Well, this is consistent with the #includes surrounding it, so I wouldn't nack
this CL for doing what's already done.

Looking at chrome_switches.h, it has included base and content switches for a
long time. There might be other files in chrome/common that does this as well.

For base, and components, since they are meant to be reused, it's good to only
#include what's necessary. The chrome directory, OTOH, is intended to be an edge
node on the other end of the dependency graph, so a little extra work for the
C++ preprocessor here is ok, since it's saving developer time and not a
frivolous #include that adds no value.

 #include "components/signin/core/common/signin_pref_names.h"
 
 namespace prefs {
 
 // Profile prefs. Please add Local State prefs below instead.
 extern const char kDefaultApps[];
 extern const char kDefaultAppsInstalled[];
 extern const char kDisableScreenshots[];
 extern const char kHomePageIsNewTabPage[];
 extern const char kHomePage[];
@@ skipping 18 matching lines @@
 extern const char kApplicationLocale[];
 #if defined(OS_CHROMEOS)
 extern const char kApplicationLocaleBackup[];
 extern const char kApplicationLocaleAccepted[];
 extern const char kOwnerLocale[];
 #endif
 
 extern const char kDefaultCharset[];
 extern const char kAcceptLanguages[];
 extern const char kStaticEncodings[];
-extern const char kShowBookmarkBar[];
-extern const char kShowAppsShortcutInBookmarkBar[];
-extern const char kBookmarkEditorExpandedNodes[];
 extern const char kWebKitCommonScript[];
 extern const char kWebKitStandardFontFamily[];
 extern const char kWebKitFixedFontFamily[];
 extern const char kWebKitSerifFontFamily[];
 extern const char kWebKitSansSerifFontFamily[];
 extern const char kWebKitCursiveFontFamily[];
 extern const char kWebKitFantasyFontFamily[];
 extern const char kWebKitPictographFontFamily[];
 
 // ISO 15924 four-letter script codes that per-script font prefs are supported
@@ skipping 281 matching lines @@
 extern const char kClearSiteDataOnExit[];
 extern const char kDefaultZoomLevel[];
 extern const char kPerHostZoomLevels[];
 extern const char kAutofillDialogAutofillDefault[];
 extern const char kAutofillDialogPayWithoutWallet[];
 extern const char kAutofillDialogWalletLocationAcceptance[];
 extern const char kAutofillDialogSaveData[];
 extern const char kAutofillDialogWalletShippingSameAsBilling[];
 extern const char kAutofillGeneratedCardBubbleTimesShown[];
 extern const char kAutofillDialogDefaults[];
-extern const char kEditBookmarksEnabled[];
 
 extern const char kPinnedTabs[];
 
 extern const char kDisable3DAPIs[];
 extern const char kEnableHyperlinkAuditing[];
 extern const char kEnableReferrers[];
 extern const char kEnableDoNotTrack[];
 
 extern const char kImportBookmarks[];
 extern const char kImportHistory[];
@@ skipping 72 matching lines @@
 extern const char kMetricsResetIds[];
 // Android has it's own metric / crash reporting implemented in Android
 // Java code so kMetricsReportingEnabled doesn't make sense. We use this
 // to inform crashes_ui that we have enabled crash reporting.
 #if defined(OS_ANDROID)
 extern const char kCrashReportingEnabled[];
 #endif
 extern const char kMetricsInitialLogs[];
 extern const char kMetricsOngoingLogs[];
 
-extern const char kBookmarkPromptEnabled[];
-extern const char kBookmarkPromptImpressionCount[];
-
 extern const char kVariationsLastFetchTime[];
 extern const char kVariationsRestrictParameter[];
 extern const char kVariationsSeed[];
 extern const char kVariationsSeedDate[];
 extern const char kVariationsSeedHash[];
 extern const char kVariationsSeedSignature[];
 
 extern const char kDeviceOpenNetworkConfiguration[];
 
 extern const char kProfileLastUsed[];
@@ skipping 440 matching lines @@
 
 #if defined(OS_ANDROID)
 extern const char kPartnerBookmarkMappings[];
 #endif
 
 extern const char kQuickCheckEnabled[];
 
 }  // namespace prefs
 
 #endif  // CHROME_COMMON_PREF_NAMES_H_