Polymorphic inlining for some recognized methods in the optimizing compiler.

runtime/vm/intrinsifier_arm.cc

Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc	(revision 25997)
+++ runtime/vm/intrinsifier_arm.cc	(working copy)
@@ -127,19 +127,6 @@
 }
 
 
-bool Intrinsifier::Array_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, Array::length_offset()));
-  __ Ret();
-  return true;

[srdjan, 2013/08/12 21:49:47]

I would not remove the intrinsics. They make startup quicker (called by
unoptimized code).

[Florian Schneider, 2013/08/14 12:30:24]

The problem is that we prohibit inlining of intrinsified methods because of
deoptimization. I _think_ we can enable it if we always emit the full
unoptimized body appended to the intrinsic code (make all intrincic-builder
functions return false).

Second, the new unoptimized code for these is only slightly slower: It enters a
stack frame, plus there is some push/pop because of the unoptimized code does
not use registers across instructions. So if the performance benefit is
negligible, I'd rather remove the code. I'll try to get some measurements.

-}
-
-
-bool Intrinsifier::ImmutableArray_getLength(Assembler* assembler) {
-  return Array_getLength(assembler);
-}
-
-
 bool Intrinsifier::Array_getIndexed(Assembler* assembler) {
   Label fall_through;
 
@@ -318,14 +305,6 @@
 }
 
 
-bool Intrinsifier::GrowableArray_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, GrowableObjectArray::length_offset()));
-  __ Ret();
-  return true;
-}
-
-
 bool Intrinsifier::GrowableArray_getCapacity(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, GrowableObjectArray::data_offset()));
@@ -546,15 +525,6 @@
   __ Bind(&fall_through);                                                      \
 
 
-// Gets the length of a TypedData.
-bool Intrinsifier::TypedData_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, TypedData::length_offset()));
-  __ Ret();
-  return true;
-}
-
-
 static int GetScaleFactor(intptr_t size) {
   switch (size) {
     case 1: return 0;
@@ -1428,14 +1398,6 @@
 }
 
 
-bool Intrinsifier::String_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, String::length_offset()));
-  __ Ret();
-  return true;
-}
-
-
 bool Intrinsifier::String_codeUnitAt(Assembler* assembler) {
   Label fall_through, try_two_byte_string;