Polymorphic inlining for some recognized methods in the optimizing compiler.

runtime/vm/intrinsifier_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 109 matching lines @@
   __ str(R3, Address(R2, 0), CC);
   __ AddImmediate(R2, kWordSize, CC);
   __ b(&init_loop, CC);
 
   __ Ret();  // Returns the newly allocated object in R0.
   __ Bind(&fall_through);
   return false;
 }
 
 
-bool Intrinsifier::Array_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, Array::length_offset()));
-  __ Ret();
-  return true;

[srdjan, 2013/08/12 21:49:47]

I would not remove the intrinsics. They make startup quicker (called by
unoptimized code).

[Florian Schneider, 2013/08/14 12:30:24]

The problem is that we prohibit inlining of intrinsified methods because of
deoptimization. I _think_ we can enable it if we always emit the full
unoptimized body appended to the intrinsic code (make all intrincic-builder
functions return false).

Second, the new unoptimized code for these is only slightly slower: It enters a
stack frame, plus there is some push/pop because of the unoptimized code does
not use registers across instructions. So if the performance benefit is
negligible, I'd rather remove the code. I'll try to get some measurements.

-}
-
-
-bool Intrinsifier::ImmutableArray_getLength(Assembler* assembler) {
-  return Array_getLength(assembler);
-}
-
-
 bool Intrinsifier::Array_getIndexed(Assembler* assembler) {
   Label fall_through;
 
   __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index
   __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array
 
   __ tst(R0, ShifterOperand(kSmiTagMask));
   __ b(&fall_through, NE);  // Index is not an smi, fall through
 
   // range check
@@ skipping 158 matching lines @@
   // Set the length field in the growable array object to 0.
   __ LoadImmediate(R1, 0);
   __ str(R1, FieldAddress(R0, GrowableObjectArray::length_offset()));
   __ Ret();  // Returns the newly allocated object in R0.
 
   __ Bind(&fall_through);
   return false;
 }
 
 
-bool Intrinsifier::GrowableArray_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, GrowableObjectArray::length_offset()));
-  __ Ret();
-  return true;
-}
-
-
 bool Intrinsifier::GrowableArray_getCapacity(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, GrowableObjectArray::data_offset()));
   __ ldr(R0, FieldAddress(R0, Array::length_offset()));
   __ Ret();
   return true;
 }
 
 
 bool Intrinsifier::GrowableArray_getIndexed(Assembler* assembler) {
@@ skipping 200 matching lines @@
   __ Bind(&init_loop);                                                         \
   __ cmp(R2, ShifterOperand(R1));                                              \
   __ str(R3, Address(R2, 0), CC);                                              \
   __ add(R2, R2, ShifterOperand(kWordSize), CC);                               \
   __ b(&init_loop, CC);                                                        \
                                                                                \
   __ Ret();                                                                    \
   __ Bind(&fall_through);                                                      \
 
 
-// Gets the length of a TypedData.
-bool Intrinsifier::TypedData_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, TypedData::length_offset()));
-  __ Ret();
-  return true;
-}
-
-
 static int GetScaleFactor(intptr_t size) {
   switch (size) {
     case 1: return 0;
     case 2: return 1;
     case 4: return 2;
     case 8: return 3;
     case 16: return 4;
   }
   UNREACHABLE();
   return -1;
@@ skipping 853 matching lines @@
 
 bool Intrinsifier::String_getHashCode(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, String::hash_offset()));
   __ cmp(R0, ShifterOperand(0));
   __ bx(LR, NE);  // Hash not yet computed.
   return false;
 }
 
 
-bool Intrinsifier::String_getLength(Assembler* assembler) {
-  __ ldr(R0, Address(SP, 0 * kWordSize));
-  __ ldr(R0, FieldAddress(R0, String::length_offset()));
-  __ Ret();
-  return true;
-}
-
-
 bool Intrinsifier::String_codeUnitAt(Assembler* assembler) {
   Label fall_through, try_two_byte_string;
 
   __ ldr(R1, Address(SP, 0 * kWordSize));  // Index.
   __ ldr(R0, Address(SP, 1 * kWordSize));  // String.
   __ tst(R1, ShifterOperand(kSmiTagMask));
   __ b(&fall_through, NE);  // Index is not a Smi.
   // Range check.
   __ ldr(R2, FieldAddress(R0, String::length_offset()));
   __ cmp(R1, ShifterOperand(R2));
@@ skipping 244 matching lines @@
   __ Bind(&ok);
   __ Ret();
 
   __ Bind(&fall_through);
   return false;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM