Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/api-natives.cc

Issue 2283713002: [api] Use handle for ConfigureInstance (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api-natives.cc
diff --git a/src/api-natives.cc b/src/api-natives.cc
index 0f3c3b69ed85fba89f72ae988e171c80c7133f3e..ed5b70f3bd1ea31e703085274f6ec46af9295176 100644
--- a/src/api-natives.cc
+++ b/src/api-natives.cc
@@ -207,7 +207,9 @@ MaybeHandle<JSObject> ConfigureInstance(Isolate* isolate, Handle<JSObject> obj,
valid_descriptors = AccessorInfo::AppendUnique(
handle(maybe_properties, isolate), array, valid_descriptors);
}
- info = info->GetParent(isolate);
+ // Make sure to use the handle since AppendUnique above might have caused
+ // a GC.
+ info = data->GetParent(isolate);
Michael Lippautz 2016/08/26 09:22:25 Let me know if this is fine or you'd prefer a loop
}
// Install accumulated accessors.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698