[api] Use handle for ConfigureInstance

src/api-natives.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api-natives.h"
 
 #include "src/api.h"
 #include "src/isolate-inl.h"
 #include "src/lookup.h"
 #include "src/messages.h"
@@ skipping 189 matching lines @@
         isolate->factory()->NewFixedArray(max_number_of_properties);
 
     info = *data;
     while (info != nullptr) {
       // Accumulate accessors.
       Object* maybe_properties = info->property_accessors();
       if (!maybe_properties->IsUndefined(isolate)) {
         valid_descriptors = AccessorInfo::AppendUnique(
             handle(maybe_properties, isolate), array, valid_descriptors);
       }
-      info = info->GetParent(isolate);
+      // Make sure to use the handle since AppendUnique above might have caused
+      // a GC.
+      info = data->GetParent(isolate);

[Michael Lippautz, 2016/08/26 09:22:25]

Let me know if this is fine or you'd prefer a loop with a temp handle.

     }
 
     // Install accumulated accessors.
     for (int i = 0; i < valid_descriptors; i++) {
       Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i)));
       JSObject::SetAccessor(obj, accessor).Assert();
     }
   }
 
   Object* maybe_property_list = data->property_list();
@@ skipping 490 matching lines @@
   if (!obj->instance_call_handler()->IsUndefined(isolate)) {
     map->set_is_callable();
     map->set_is_constructor(true);
   }
 
   return result;
 }
 
 }  // namespace internal
 }  // namespace v8