Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2283713002:
[api] Use handle for ConfigureInstance (Closed)
|
Created:
4 years, 3 months ago by Michael Lippautz Modified:
4 years, 3 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[api] Use handle for ConfigureInstance
BUG=chromium:641267
R=verwaest@chromium.org
Committed: https://crrev.com/2059fb0ba6d76e00b51c0651a2af554dea44319f
Cr-Commit-Position: refs/heads/master@{#38942}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rewrite using temp handle #Patch Set 3 : Bring back comment #Messages
Total messages: 23 (18 generated)
Description was changed from ========== [api] Use handle for ConfigureInstance BUG=chromium:641267 ========== to ========== [api] Use handle for ConfigureInstance BUG=chromium:641267 R=verwaest@chromium.org ==========
mlippautz@chromium.org changed reviewers: + verwaest@chromium.org
https://codereview.chromium.org/2283713002/diff/1/src/api-natives.cc File src/api-natives.cc (right): https://codereview.chromium.org/2283713002/diff/1/src/api-natives.cc#newcode212 src/api-natives.cc:212: info = data->GetParent(isolate); Let me know if this is fine or you'd prefer a loop with a temp handle.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, gee
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/2283713002/#ps40001 (title: "Bring back comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [api] Use handle for ConfigureInstance BUG=chromium:641267 R=verwaest@chromium.org ========== to ========== [api] Use handle for ConfigureInstance BUG=chromium:641267 R=verwaest@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [api] Use handle for ConfigureInstance BUG=chromium:641267 R=verwaest@chromium.org ========== to ========== [api] Use handle for ConfigureInstance BUG=chromium:641267 R=verwaest@chromium.org Committed: https://crrev.com/2059fb0ba6d76e00b51c0651a2af554dea44319f Cr-Commit-Position: refs/heads/master@{#38942} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2059fb0ba6d76e00b51c0651a2af554dea44319f Cr-Commit-Position: refs/heads/master@{#38942} |
