Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2283373002: Remove unneeded scoped_refptr<>::get() on method binding (Closed)

Created:
4 years, 3 months ago by tzik
Modified:
4 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, cmumford, darin-cc_chromium.org, eroman, extensions-reviews_chromium.org, grt+watch_chromium.org, jam, jsbell+idb_chromium.org, michaeln, mlamouri+watch-content_chromium.org, pam+watch_chromium.org, piman+watch_chromium.org, sync-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded scoped_refptr<>::get() on method binding This CL is generated by a clang tool being added by http://crrev.com/2283003002. scoped_refptr<>::get() on method bindings are unneeded, are a source of implicit raw pointer to scoped_refptr<> conversion, and make following refactoring less mechanical. This CL removes most of get() call throughout the source tree. BUG=589048 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/07cace49f17b6638bec5f32fcdef4de901de9253 Cr-Commit-Position: refs/heads/master@{#415878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -111 lines) Patch
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/zipfile_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/profile_import_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_service.cc View 42 chunks +43 lines, -43 lines 0 comments Download
M components/invalidation/impl/non_blocking_invalidator.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/ipc/client/gpu_channel_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/base/test_completion_callback_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
tzik
PTAL to: vmpstr: FYI, jochen: //chrome, //component, //content, sergeyu@chromium.org: //jingle piman@chromium.org: //gpu mmenke@chromium.org: //net rockot@chromium.org: ...
4 years, 3 months ago (2016-08-30 14:15:59 UTC) #12
mmenke
net/ LGTM
4 years, 3 months ago (2016-08-30 14:25:03 UTC) #13
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-08-30 16:51:32 UTC) #14
piman
LGTM for content/ and gpu/
4 years, 3 months ago (2016-08-30 17:22:51 UTC) #15
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-31 14:27:40 UTC) #16
Sergey Ulanov
lgtm
4 years, 3 months ago (2016-08-31 18:26:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283373002/1
4 years, 3 months ago (2016-09-01 03:08:19 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 04:22:50 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 04:35:09 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07cace49f17b6638bec5f32fcdef4de901de9253
Cr-Commit-Position: refs/heads/master@{#415878}

Powered by Google App Engine
This is Rietveld 408576698