Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/extensions/zipfile_installer_unittest.cc

Issue 2283373002: Remove unneeded scoped_refptr<>::get() on method binding (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 original_path = original_path.AppendASCII("extensions") 93 original_path = original_path.AppendASCII("extensions")
94 .AppendASCII("zipfile_installer") 94 .AppendASCII("zipfile_installer")
95 .AppendASCII(zip_name); 95 .AppendASCII(zip_name);
96 ASSERT_TRUE(base::PathExists(original_path)) << original_path.value(); 96 ASSERT_TRUE(base::PathExists(original_path)) << original_path.value();
97 97
98 zipfile_installer_ = ZipFileInstaller::Create(extension_service_); 98 zipfile_installer_ = ZipFileInstaller::Create(extension_service_);
99 99
100 base::ThreadTaskRunnerHandle::Get()->PostTask( 100 base::ThreadTaskRunnerHandle::Get()->PostTask(
101 FROM_HERE, 101 FROM_HERE,
102 base::Bind(&ZipFileInstaller::LoadFromZipFile, 102 base::Bind(&ZipFileInstaller::LoadFromZipFile,
103 zipfile_installer_.get(), 103 zipfile_installer_,
104 original_path)); 104 original_path));
105 observer_.WaitForInstall(); 105 observer_.WaitForInstall();
106 } 106 }
107 107
108 protected: 108 protected:
109 scoped_refptr<ZipFileInstaller> zipfile_installer_; 109 scoped_refptr<ZipFileInstaller> zipfile_installer_;
110 110
111 std::unique_ptr<TestingProfile> profile_; 111 std::unique_ptr<TestingProfile> profile_;
112 ExtensionService* extension_service_; 112 ExtensionService* extension_service_;
113 113
(...skipping 14 matching lines...) Expand all
128 RunInstaller("good.zip"); 128 RunInstaller("good.zip");
129 } 129 }
130 130
131 TEST_F(ZipFileInstallerTest, ZipWithPublicKey) { 131 TEST_F(ZipFileInstallerTest, ZipWithPublicKey) {
132 RunInstaller("public_key.zip"); 132 RunInstaller("public_key.zip");
133 const char kIdForPublicKey[] = "ikppjpenhoddphklkpdfdfdabbakkpal"; 133 const char kIdForPublicKey[] = "ikppjpenhoddphklkpdfdfdabbakkpal";
134 EXPECT_EQ(observer_.last_extension_installed, kIdForPublicKey); 134 EXPECT_EQ(observer_.last_extension_installed, kIdForPublicKey);
135 } 135 }
136 136
137 } // namespace extensions 137 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_creator.cc ('k') | chrome/browser/printing/print_view_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698