Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/dom/DOMMatrix.idl

Issue 2283363003: GeometryInterface: Add DOMMatrixInit and fromMatrix(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMMatrix.idl
diff --git a/third_party/WebKit/Source/core/dom/DOMMatrix.idl b/third_party/WebKit/Source/core/dom/DOMMatrix.idl
index 44a684e6eb962e37194f38f61fc1272dfef32d91..02f21de4ffe8f9cabd26b2627660d0cb983f6d41 100644
--- a/third_party/WebKit/Source/core/dom/DOMMatrix.idl
+++ b/third_party/WebKit/Source/core/dom/DOMMatrix.idl
@@ -11,6 +11,8 @@
// FIXME: Exposed=(Window,Worker)
RuntimeEnabled=GeometryInterfaces,
] interface DOMMatrix : DOMMatrixReadOnly {
+ [RaisesException, NewObject] static DOMMatrix fromMatrix(optional DOMMatrixInit other);
+
// These attributes are simple aliases for certain elements of the 4x4 matrix
inherit attribute unrestricted double a;
inherit attribute unrestricted double b;
@@ -38,8 +40,8 @@
// FIXME: Should implement some methods (See: crbug.com/388780)
dominicc (has gone to gerrit) 2016/09/12 05:19:43 Might be nice to update add a comment to this bug
zino 2016/09/12 09:12:42 Done.
// Mutable transform methods
- DOMMatrix multiplySelf(DOMMatrix other);
- DOMMatrix preMultiplySelf(DOMMatrix other);
+ [RaisesException] DOMMatrix multiplySelf(optional DOMMatrixInit other);
+ [RaisesException] DOMMatrix preMultiplySelf(optional DOMMatrixInit other);
DOMMatrix translateSelf(unrestricted double tx,
unrestricted double ty,
optional unrestricted double tz = 0);

Powered by Google App Engine
This is Rietveld 408576698