Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html

Issue 2283363003: GeometryInterface: Add DOMMatrixInit and fromMatrix(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html » ('j') | third_party/WebKit/Source/core/dom/DOMMatrix.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html b/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html
index f394c57d40b7fa85fa610fefe4f3edc1b449166a..9f7f5cf10e61ea492cdae93708578a1e733517f1 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html
@@ -4,11 +4,12 @@
<title>Geometry Interfaces: DOMMatrix</title>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
+<script src="./resources/geometry-interfaces-test-helpers.js"></script>
</head>
<body>
<script>
-test(function() {
+test(() => {
var matrix = new DOMMatrix();
assert_equals(matrix.m11, 1);
assert_equals(matrix.m12, 0);
@@ -30,7 +31,7 @@ test(function() {
assert_true(matrix.isIdentity);
}, "DOMMatrix() constructor");
-test(function() {
+test(() => {
var other = new DOMMatrix();
other.m11 = 10;
other.m12 = 20;
@@ -60,7 +61,7 @@ test(function() {
assert_false(matrix.isIdentity);
}, "DOMMatrix(other) constructor");
-test(function() {
+test(() => {
var matrix = new DOMMatrix();
matrix.a = 10;
matrix.b = 20;
@@ -94,7 +95,7 @@ test(function() {
assert_false(matrix.isIdentity);
}, "DOMMatrix attributes");
-test(function() {
+test(() => {
var matrix = new DOMMatrix();
assert_true(matrix.is2D);
assert_true(matrix.isIdentity);
@@ -108,6 +109,85 @@ test(function() {
assert_true(matrix.isIdentity);
}, "DOMMatrix.is2D can never be set to 'true' when it was set to 'false' before calling setMatrixValue().");
+test(() => {
+ assert_identity_2d_matrix(DOMMatrix.fromMatrix());
+}, "DOMMatrix.fromMatrix() with no parameter.");
+
+test(() => {
+ assert_identity_2d_matrix(DOMMatrix.fromMatrix(null));
+}, "DOMMatrix.fromMatrix() with null.");
+
+test(() => {
+ assert_identity_2d_matrix(DOMMatrix.fromMatrix(undefined));
+}, "DOMMatrix.fromMatrix() with undefined.");
+
+test(() => {
+ assert_identity_2d_matrix(DOMMatrix.fromMatrix({}));
+}, "DOMMatrix.fromMatrix() with empty object.");
+
+test(() => {
+ var matrix = DOMMatrix.fromMatrix({a: 1, b: 2, c: 3, d: 4, e: 5, f: 6});
+ assert_2d_matrix_equals(matrix, {
+ m11: 1, m12: 2,
+ m21: 3, m22: 4,
+ m41: 5, m42: 6,
+ isIdentity: false
+ });
+}, "DOMMatrix.fromMatrix({a: 1, b: 2, c: 3, d: 4, e: 5, f: 6}) should create a 2D DOMMatrix.");
+
+test(() => {
+ var matrix = DOMMatrix.fromMatrix({m11: 1, m22: 2, m33: 3, m44: 4, m23: 5, m43: 6});
+ assert_3d_matrix_equals(matrix, {
+ m11: 1, m12: 0, m13: 0, m14: 0,
+ m21: 0, m22: 2, m23: 5, m24: 0,
+ m31: 0, m32: 0, m33: 3, m34: 0,
+ m41: 0, m42: 0, m43: 6, m44: 4,
+ isIdentity: false
+ });
+}, "DOMMatrix.fromMatrix({m11: 1, m22: 2, m33: 3, m44: 4, m23: 5, m43: 6}) should create a 3D DOMMatrix.");
+
+test(() => {
+ var matrix = DOMMatrix.fromMatrix({a: 7, c: 9});
+ assert_2d_matrix_equals(matrix, {
+ m11: 7, m12: 0,
+ m21: 9, m22: 1,
+ m41: 0, m42: 0,
+ isIdentity: false
+ });
+}, "If 2d related properties don't be set, should set to fallback.");
+
+test(() => {
+ var matrix = DOMMatrix.fromMatrix({
+ m11: NaN, m12: NaN, m13: NaN, m14: NaN,
+ m21: NaN, m22: NaN, m23: NaN, m24: NaN,
+ m31: NaN, m32: NaN, m33: NaN, m34: NaN,
+ m41: NaN, m42: NaN, m43: NaN, m44: NaN,
+ is2D: false
+ });
+ assert_equals(matrix.a, matrix.m11);
+ assert_equals(matrix.b, matrix.m12);
+ assert_equals(matrix.c, matrix.m21);
+ assert_equals(matrix.d, matrix.m22);
+ assert_equals(matrix.e, matrix.m41);
+ assert_equals(matrix.f, matrix.m42);
+ assert_3d_matrix_equals(matrix, {
+ m11: NaN, m12: NaN, m13: NaN, m14: NaN,
+ m21: NaN, m22: NaN, m23: NaN, m24: NaN,
+ m31: NaN, m32: NaN, m33: NaN, m34: NaN,
+ m41: NaN, m42: NaN, m43: NaN, m44: NaN,
+ isIdentity: false, is2D: false
+ });
+}, "DOMMatrix.fromMatrix(): NaN test");
+
+test(() => {
+ assert_throws(new TypeError(), () => {
+ var matrix = DOMMatrix.fromMatrix({a: 1, b: 2, m33: 3, m44: 4, is2D: true});
+ }, "The 'is2D' property is set to true but the input matrix is 3d matrix.");
+ assert_throws(new TypeError(), () => {
+ var matrix = DOMMatrix.fromMatrix({a: 1, b: 2, m11: 3});
+ }, "The 'a' property should equal the 'm11' property.");
+}, "DOMMatrix.fromMatrix(): Exception test.");
+
</script>
</body>
</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html » ('j') | third_party/WebKit/Source/core/dom/DOMMatrix.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698